Skip to content

Adds into_pyarray to faer Mat#482

Open
wgurecky wants to merge 8 commits into
PyO3:mainfrom
wgurecky:faer_compat
Open

Adds into_pyarray to faer Mat#482
wgurecky wants to merge 8 commits into
PyO3:mainfrom
wgurecky:faer_compat

Conversation

@wgurecky

@wgurecky wgurecky commented Mar 10, 2025

Copy link
Copy Markdown

Interoperability with faer (https://github.com/sarah-quinones/faer-rs) Mats.

Related faer-ext PR for numpy-to-faer direction: sarah-quinones/faer-ext#6 . For bi-directional interoperability of faer with python/numpy. @sarah-quinones

@davidhewitt davidhewitt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs CI fixing please

Comment thread src/convert.rs
@davidhewitt davidhewitt mentioned this pull request Mar 13, 2025
@davidhewitt

Copy link
Copy Markdown
Member

Looks like this has hit a build issue with faer.

@wgurecky

wgurecky commented Mar 14, 2025

Copy link
Copy Markdown
Author

Looks like this has hit a build issue with faer.

yes, on windows x86 :/ . I don't have a good way to test on windows locally. Looks like a small change is needed in the faer-traits crate.

@wgurecky

Copy link
Copy Markdown
Author

Looks like this has hit a build issue with faer.

Updated to the latest faer version which contains a fix for this build issue.

There is a second issue, however. faer requires msrv of 1.84.0. If this is an issue, might have to either conditionally allow this optional faer feature, or, consider implementing IntoPyArray for faer Mats in faer itself

@wgurecky wgurecky requested a review from davidhewitt March 19, 2025 04:40
@davidhewitt

Copy link
Copy Markdown
Member

There still seem to be issues with Windows here.

If this is an issue, might have to either conditionally allow this optional faer feature, or, consider implementing IntoPyArray for faer Mats in faer itself

Given the seeming complexity with the CI on this end, this may be simpler (esp if faer has already implemented the reverse conversion over there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants