[Refactor] Use constant lookup map for architectures in platformAndArch#8173
[Refactor] Use constant lookup map for architectures in platformAndArch#8173gonzaloriestra wants to merge 1 commit into
Conversation
Refactored `platformAndArch` in `packages/cli-kit/src/public/node/os.ts` to use a declarative mapping constant `ARCH_MAP` and the nullish coalescing operator `??` instead of imperative `if/else` checks. This aligns with modern JS/TS patterns and improves readability.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
This clean-up simplifies and modularizes the CPU architecture determination in
platformAndArch(part of the@shopify/cli-kitworkspace).WHAT is this pull request doing?
Refactors
platformAndArchinpackages/cli-kit/src/public/node/os.tsby:x64toamd64andia32to386into a clean, top-level lookup constant (ARCH_MAP).if/elseblock and using nullish coalescing (??) to fallback to the raw architecture string.No observable behavior changes are introduced.
How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 9085943036394304505 started by @gonzaloriestra