Skip to content

fix(aria/combobox): allow setting readonly#33364

Draft
ok7sai wants to merge 1 commit into
angular:mainfrom
ok7sai:fix/combobox-readonly
Draft

fix(aria/combobox): allow setting readonly#33364
ok7sai wants to merge 1 commit into
angular:mainfrom
ok7sai:fix/combobox-readonly

Conversation

@ok7sai

@ok7sai ok7sai commented Jun 8, 2026

Copy link
Copy Markdown
Member

Fixes #33352

@ok7sai ok7sai force-pushed the fix/combobox-readonly branch 2 times, most recently from fae8734 to 67b092d Compare June 8, 2026 08:30
@ok7sai ok7sai added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Jun 8, 2026
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deployed dev-app for 213728a to: https://ng-dev-previews-comp--pr-angular-components-33364-dev-vufoprht.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@rudzikdawid

rudzikdawid commented Jun 8, 2026

Copy link
Copy Markdown

Thanks for restoring readonly! However, it looks like the disabled state is still not behaving correctly.

I tested the dev-app preview, and in the "Combobox with disabled" section, I was still able to click the input, focus it, and type text ("i can write here").

Zrzut ekranu z 2026-06-08 21-31-36

Current behavior: A disabled combobox accepts focus and allows text editing.

Expected behavior: A disabled element should be completely inactive — it should be uneditable and unfocusable (skipped during tab navigation). For comparison, in the standard Angular Material Input examples, the disabled control is correctly excluded from the tab order and cannot be interacted with.

@ok7sai

ok7sai commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

Thanks for reviewing! This PR is an early draft that needs to be polished.

@ok7sai ok7sai force-pushed the fix/combobox-readonly branch from 67b092d to 213728a Compare June 8, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: aria/combobox dev-app preview When applied, previews of the dev-app are deployed to Firebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(aria/combobox): Focus management and a11y regressions: Combobox missing readonly, Select disabled is focusable

2 participants