From 2b0cfd9d2fc8fafa79cc79f3c5f7576cb68a6676 Mon Sep 17 00:00:00 2001 From: naman Date: Fri, 11 Sep 2026 19:58:10 +0530 Subject: [PATCH] chore(ci): Register the substrait check job with runs-on, route spark checks through xtask Two small inconsistencies in the `cargo check features` jobs. `cargo check datafusion-substrait features` selects a `runs-on` runner with `extras=s3-cache`, but is the only one of the fifteen jobs that select such a runner without the `runs-on/action` step that registers it. Without that step the job gets neither the external cache nor the job metrics the other fourteen report. `cargo check datafusion-spark features` is the last place in the workflow that calls `cargo check` directly rather than going through `cargo xtask ci step check`, so those three checks cannot be reproduced locally the way every other check step can. The three commands xtask emits are identical to the ones being replaced: default -> cargo check --profile ci --all-targets -p datafusion-spark no-default -> cargo check --profile ci --no-default-features -p datafusion-spark core -> cargo check --profile ci --no-default-features -p datafusion-spark --features core Job names are unchanged, so the required checks in `.asf.yaml` are unaffected. --- .github/workflows/rust.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index e51215f99174f..5179e3cd64d35 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -115,6 +115,7 @@ jobs: container: image: amd64/rust steps: + - uses: runs-on/action@efac073ea2507ec18797de3a81704201ade11d9d # v2.3.1 - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - name: Setup Rust toolchain uses: ./.github/actions/setup-builder @@ -315,14 +316,14 @@ jobs: with: rust-version: stable - name: Check datafusion-spark (default features) - run: cargo check --profile ci --all-targets -p datafusion-spark + run: cargo xtask ci step check datafusion-spark default # # Note: Only check libraries (not --all-targets) to cover end user APIs # - name: Check datafusion-spark (no-default-features) - run: cargo check --profile ci --no-default-features -p datafusion-spark + run: cargo xtask ci step check datafusion-spark no-default - name: Check datafusion-spark (core) - run: cargo check --profile ci --no-default-features -p datafusion-spark --features=core + run: cargo xtask ci step check datafusion-spark core # Library and integration tests linux-test: