Skip to content
This repository was archived by the owner on Feb 11, 2025. It is now read-only.
This repository was archived by the owner on Feb 11, 2025. It is now read-only.

invoice object returns a Vec<Parcel> as type "parcel" #333

@bacongobbler

Description

@bacongobbler

Should these fields be made plural to match other fields?

pub parcel: Option<Vec<Parcel>>,
pub group: Option<Vec<Group>>,
pub signature: Option<Vec<Signature>>,

IMO we should be listing these as "parcels", "groups", and "signatures" as we're dealing with a list of objects rather than a single object.

That being said, this would break backwards compatibility with older bindle clients.

I noticed this while updating bindle-dotnet to the newest bindle APIs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions