Repository navigation
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
marked this pull request as ready for review
November 5, 2026 11:35
4 of 10 tasks
yiyixuxu
reviewed
Nov 13, 2026
|
|
||
|
|
||
| @dataclass | ||
| class DifferentiableProjectiveCamera: |
Collaborator
There was a problem hiding this comment.
ohh I think we can deprecate shap-e too, no?
Member
Author
There was a problem hiding this comment.
Just deprecated in the pipeline location, following what others are doing:
a647ae1
Follow-up PT will change the deprecation to use remote elements (will convert to remote) there in the PR.
LMK if you had in mind something else for deprecation.
Member
Author
There was a problem hiding this comment.
Or did you mean we deprecate IF and SHAP-E like:
https://github.com/huggingface/diffusers/tree/main/src/diffusers/pipelines/deprecated
Member
Author
|
Failing tests are unrelated. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate the philosophy of #15111 throughout Diffusers.
Classification details below.
autoencodersnow includes the ACE step tokenizer, LTX2 vocoder, SHAP-E renderer with the camera related stuff.unetshas the AudioLDM2 UNet.condition_embeddershas the Stable unCLIP normalizer.As discussed internally, we will deal with the rest of the elements through a combination of deprecation and remote elements.othersfor everything else where we cannot make a substantial difference and when the patterns aren't common enough.