Skip to content

Use InstanceNetworkInterfaceListAllPages for NIC listing #274

Description

@sudomateo

Context

InstanceMetadata (internal/provider/instances_v2.go) calls InstanceNetworkInterfaceList and reads only the first results page. Oxide's per-instance NIC cap makes this safe in practice today, but the oxide.go SDK provides InstanceNetworkInterfaceListAllPages, which removes the question permanently.

Scope

Replace the single-page call with the AllPages variant; update the oxideInstanceClient interface and test fakes accordingly.

Done when

NIC listing cannot silently truncate, and mocks/tests reflect the new interface method.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions