gh-139819: rlcompleter – avoid suggesting attributes not accessible on instances#139820
Merged
Conversation
Contributor
Author
|
Noted the CI Test failure. I’m working on a fix and will push soon. |
… in rlcompleter tests
Contributor
Author
|
Tests have passed. Thanks for reviewing! |
|
This PR is stale because it has been open for 30 days with no activity. |
clin1234
pushed a commit
to clin1234/cpython
that referenced
this pull request
Jun 9, 2026
…ible on instances (pythonGH-139820) Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
danielhollas
reviewed
Jun 9, 2026
| __all__ = ["Completer"] | ||
|
|
||
| # Sentinel object to distinguish "missing" from "present but None" | ||
| _SENTINEL = object() |
Contributor
There was a problem hiding this comment.
Should this use the new sentinel builtin?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix tab-completion suggesting names that are not accessible on instances
(e.g., Enum members showing
__name__).Change
In
rlcompleter.attr_matches(), whengetattr(thisobject, word, None)is None, only add the candidate if
hasattr(thisobject, word)is true.Effect
Removes bogus suggestions without affecting valid completions.
Bogus suggestions