Skip to content

[AKS] Fix #34091: az aks get-credentials: Fix kubelogin conversion for explicit kubeconfig paths - #34104

Open
Aditya Pujara (a0x1ab) wants to merge 1 commit into
Azure:devfrom
a0x1ab:agent-assist/azure-azure-cli-issue-34091-63d5031c5731
Open

Aditya Pujara (a0x1ab) wants to merge 1 commit into
Azure:devfrom
a0x1ab:agent-assist/azure-azure-cli-issue-34091-63d5031c5731

Conversation

@a0x1ab

@a0x1ab Aditya Pujara (a0x1ab) commented Sep 19, 2026

Copy link
Copy Markdown
Member

🤖 PR Validation — ️✔️ All clear

Breaking Changes Tests
️✔️ None ️✔️ 130/130

Related command

az aks get-credentials

Description

Fixes #34091.

Implemented by X Engineering Agent using Azure AI Foundry. This is an AI-generated change, published by the configured operator.

Testing Guide

  • Run az aks get-credentials.
  • Focused regression coverage: src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py.
  • Repository CI and the authorized live-test workflow validate the published revision.

History Notes

[AKS] az aks get-credentials: Fix kubelogin conversion for explicit kubeconfig paths


This checklist is used to make sure that common guidelines for a pull request are followed.

…sion for explicit kubeconfig paths

AI-generated by X Engineering Agent via Azure AI Foundry.
Foundry-Job: 63d5031c5731ded4cf8b3593b8e493b3b2ed1abc96581152b52b8dc23740b9dc
@x-engineering-agent x-engineering-agent Bot added the Request X Engineering Agent Request X Engineering Agent testing and review label Sep 19, 2026
@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 13:35
@x-engineering-agent
x-engineering-agent Bot requested a review from a team as a code owner September 19, 2026 13:35
Copilot AI lite review requested due to automatic review settings September 19, 2026 13:35
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Resolve the critical risk of launching an unintended kubelogin executable instead of the resolved PATH executable.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity

Open (1)
What changed in this PR

Fixes az aks get-credentials kubelogin conversion when an explicit kubeconfig path is used.

Changes:

  • Passes the selected kubeconfig path to kubelogin.
  • Adds regression coverage for conversion, path handling, failures, and security cases.
File Summary
src/​azure-cli/​azure/​cli/​command_modules/​acs/​tests/​latest/​test_custom.py Adds focused regression coverage.
src/​azure-cli/​azure/​cli/​command_modules/​acs/​custom.py Updates kubelogin conversion invocation.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +1951 to +1956
if path != "-" and uses_kubelogin_devicecode(kubeconfig):
if which("kubelogin"):
try:
# Run kubelogin convert-kubeconfig -l azurecli
# Select the merged file without changing how relative paths are resolved.
subprocess.run(
["kubelogin", "convert-kubeconfig", "-l", "azurecli"],
cwd=os.path.dirname(path),
["kubelogin", "convert-kubeconfig", "-l", "azurecli", "--kubeconfig", path],
@a0x1ab

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 14:04
@x-engineering-agent

Copy link
Copy Markdown
Contributor

Live test results — azdev test --live --series (changed test files only)

PASS

Selectors: acs.test_custom (module)
PR head ref: agent-assist/azure-azure-cli-issue-34091-63d5031c5731
PR head sha: 9704e4cd70f95fc98b7495cbe4465bc302c2c414
PR base ref: dev
New test files in PR: false

Changed test files run
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py

Workflow run: https://github.com/Azure/issue-sentinel/actions/runs/35447617027

Last 80 lines of azdev output
cachedir: .pytest_cache
rootdir: /home/runner/work/issue-sentinel/issue-sentinel/azure-cli/src/azure-cli
plugins: forked-1.7.5, xdist-3.8.0
collecting ... collected 72 items

azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AksGetCredentialsTest::test_get_credentials_conversion_failure_warns PASSED [  1%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AksGetCredentialsTest::test_get_credentials_conversion_paths PASSED [  2%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AksGetCredentialsTest::test_get_credentials_converts_selected_kubeconfig PASSED [  4%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AksGetCredentialsTest::test_get_credentials_missing_kubelogin_warns PASSED [  5%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AksGetCredentialsTest::test_get_credentials_nonzero_kubelogin_exit PASSED [  6%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AksGetCredentialsTest::test_get_credentials_preserves_overwrite_context_and_admin PASSED [  8%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AksGetCredentialsTest::test_get_credentials_rejects_symlink_before_conversion PASSED [  9%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AksGetCredentialsTest::test_get_credentials_stdout_skips_conversion PASSED [ 11%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AksGetCredentialsTest::test_get_credentials_without_devicecode_skips_conversion PASSED [ 12%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_get_latest_kubelogin_version_all_sources_fail PASSED [ 13%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_get_latest_kubelogin_version_fallback_only_on_rate_limit PASSED [ 15%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_get_latest_kubelogin_version_fallback_without_tag_prefix PASSED [ 16%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_get_latest_kubelogin_version_unexpected_fallback_content PASSED [ 18%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_k8s_install_kubectl_create_installation_dir PASSED [ 19%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_k8s_install_kubectl_emit_warnings PASSED [ 20%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_k8s_install_kubectl_with_custom_source_url PASSED [ 22%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_k8s_install_kubelogin_create_installation_dir PASSED [ 23%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_k8s_install_kubelogin_emit_warnings PASSED [ 25%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_k8s_install_kubelogin_latest_version_fallback PASSED [ 26%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_k8s_install_kubelogin_with_custom_source_url SKIPPED [ 27%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_k8s_install_kubelogin_with_gh_token PASSED [ 29%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_merge_admin_credentials PASSED [ 30%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_merge_credentials PASSED [ 31%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_merge_credentials_already_present PASSED [ 33%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_merge_credentials_broken_yaml PASSED [ 34%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_merge_credentials_missing PASSED [ 36%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_merge_credentials_non_existent PASSED [ 37%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_merge_credentials_rejects_symlink PASSED [ 38%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_update_addons PASSED [ 40%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AcsCustomCommandTest::test_update_upgrade_settings PASSED [ 41%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAKSCommand::test_aks_agentpool_auto_scale_add_non_vms_pool PASSED [ 43%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAKSCommand::test_aks_agentpool_auto_scale_add_success PASSED [ 44%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAKSCommand::test_aks_agentpool_auto_scale_delete_non_vms_pool PASSED [ 45%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAKSCommand::test_aks_agentpool_auto_scale_delete_profile_not_found PASSED [ 47%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAKSCommand::test_aks_agentpool_auto_scale_delete_success PASSED [ 48%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAKSCommand::test_aks_agentpool_auto_scale_update_missing_required PASSED [ 50%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAKSCommand::test_aks_agentpool_auto_scale_update_profile_not_found PASSED [ 51%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAKSCommand::test_aks_agentpool_auto_scale_update_success PASSED [ 52%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAKSCommand::test_aks_stop PASSED [ 54%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAKSCommand::test_aks_upgrade_kubernetes_version_skips_machines_mode_pool PASSED [ 55%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAKSCommand::test_aks_upgrade_node_image_only_skips_machines_mode_pool PASSED [ 56%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestRunCommand::test_get_command_context_empty PASSED [ 58%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestRunCommand::test_get_command_context_invalid_file PASSED [ 59%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestRunCommand::test_get_command_context_mixed PASSED [ 61%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestRunCommand::test_get_command_context_valid PASSED [ 62%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAddonConfigurationAzureBleuCloud::test_bleufrancecentral_region_mapping PASSED [ 63%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAddonConfigurationAzureBleuCloud::test_bleufrancesouth_region_mapping PASSED [ 65%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAddonConfigurationAzureBleuCloud::test_unknown_bleu_region_defaults_to_bleufrancecentral PASSED [ 66%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAddonConfigurationAzureDelosCloud::test_deloscloudgermanycentral_region_mapping PASSED [ 68%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAddonConfigurationAzureDelosCloud::test_deloscloudgermanynorth_region_mapping PASSED [ 69%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAddonConfigurationAzureDelosCloud::test_unknown_delos_region_defaults_to_deloscloudgermanycentral PASSED [ 70%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestIsMonitoringAddonEnabled::test_monitoring_disabled_with_camelcase_key PASSED [ 72%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestIsMonitoringAddonEnabled::test_monitoring_enabled_with_camelcase_key PASSED [ 73%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestIsMonitoringAddonEnabled::test_monitoring_enabled_with_lowercase_key PASSED [ 75%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestIsMonitoringAddonEnabled::test_no_monitoring_addon_at_all PASSED [ 76%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestIsMonitoringAddonEnabled::test_non_monitoring_addon PASSED [ 77%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAksEnableAddonsAutoHLSM::test_hlsm_auto_enabled_when_cnl_active PASSED [ 79%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAksEnableAddonsAutoHLSM::test_hlsm_auto_enabled_with_cnl_lowercase_true PASSED [ 80%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAksEnableAddonsAutoHLSM::test_hlsm_explicit_false_not_overridden_by_cnl PASSED [ 81%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAksEnableAddonsAutoHLSM::test_hlsm_explicit_true_not_overridden PASSED [ 83%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAksEnableAddonsAutoHLSM::test_hlsm_not_auto_enabled_when_cnl_false PASSED [ 84%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::TestAksEnableAddonsAutoHLSM::test_hlsm_not_auto_enabled_when_cnl_inactive PASSED [ 86%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AksAgentpoolUpgradeTest::test_aks_agentpool_upgrade_sets_max_unavailable PASSED [ 87%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AksAgentpoolRollbackTest::test_aks_agentpool_get_rollback_versions_returns_recently_used_versions PASSED [ 88%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AksAgentpoolRollbackTest::test_aks_agentpool_rollback_prioritizes_upgrade_channel_warning PASSED [ 90%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AksAgentpoolRollbackTest::test_aks_agentpool_rollback_raises_when_no_recent_versions PASSED [ 91%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AksAgentpoolRollbackTest::test_aks_agentpool_rollback_uses_most_recent_version PASSED [ 93%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::AksAgentpoolRollbackTest::test_aks_agentpool_rollback_warns_node_image_only_for_node_os_channel PASSED [ 94%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::DcrTableReadinessRetryTest::test_other_errors_keep_three_attempt_limit PASSED [ 95%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::DcrTableReadinessRetryTest::test_raises_after_readiness_retry_limit PASSED [ 97%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::DcrTableReadinessRetryTest::test_retries_invalid_output_table_with_delay PASSED [ 98%]
azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py::DcrTableReadinessRetryTest::test_succeeds_without_retry PASSED [100%]

- generated xml file: /home/runner/work/issue-sentinel/issue-sentinel/test-output/results.xml -
======================== 71 passed, 1 skipped in 2.09s =========================

Posted by the X Engineering Agent live-test workflow.

@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 14:13
@a0x1ab

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 15:26
@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 15:39
@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 15:42
@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 15:50
@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 15:53
@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 16:04
@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 18:33
@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 18:48
@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 18:49
@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 19:04
@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 19:05
@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 19:30
@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 19:31
@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 19:50
@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 19:53
@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 20:09
@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 20:09
@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 20:25
@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 20:31
@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 20:45
@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 20:47
@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 20:59
@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 21:03
@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 21:13
@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 21:13
@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 21:28
@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 21:29
@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 21:48
@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 21:51
@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 22:05
@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 22:07
@x-engineering-agent
x-engineering-agent Bot marked this pull request as ready for review September 19, 2026 22:20
@a0x1ab
Aditya Pujara (a0x1ab) marked this pull request as draft September 19, 2026 22:23

@x-engineering-agent x-engineering-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aditya Pujara (@a0x1ab)

Automated validation and bounded review

Reviewed 9704e4cd70f95fc98b7495cbe4465bc302c2c414. The supplied validation succeeded, with no confirmed code defect or deterministic policy finding. This COMMENT is not an approval.

Upstream CI

53/53 checks passed; 0 failed, 0 pending, 0 cancelled. No CI failures require relevance classification.

Test validation

  • Live test: Passed. Workflow run
  • Regression coverage: Present for acs: 1 focused test file(s) changed.
  • Focused evidence: AksGetCredentialsTest covers relative, absolute and spaced paths, KUBECONFIG precedence, stdout isolation, converter absence/failure, context/admin behavior and symlink rejection. The POSIX subprocess cases use a converter fixture, not the real kubelogin binary.
  • Recording scope: No recordings changed. The inspected diff changes local destination selection and stdout handling, not credential API arguments or response decoding; no HTTP re-recording requirement is established by this diff.
  • Validation boundary: Used the existing CI snapshot and the supplied current-head workflow result; this review launched no tests or workflows.

Repository review

All seven skills were accounted for: release artifacts, generated ownership (not applicable), command/help conventions (not applicable), test strength, user intent, scope consistency and domain edge cases.

The component title/History Notes match the fix; only handwritten ACS code and its focused tests change. At custom.py:1951–1963, stdout bypasses conversion, file destinations pass the same selected merge path explicitly without changing the working directory, and converter errors retain warning-only handling.

Risk assessment

16/100 · Low · High confidence

The Low rating is driven by public CLI behavior.

  • Change scope: 2 changed files, 248 changed lines (+244 / -4), including 1 production file.
  • Affected components: acs
  • Risk drivers: public CLI behavior (+18)
  • Regression evidence: Changed regression tests are included, reducing risk.
  • Confidence: High because changed-line patches were available for every production file.
  • Required review: Owning-squad review is recommended for acs before merge.

@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

🔔 Routing this PR to @Azure/act-observability-squad.

@FumingZhang

Copy link
Copy Markdown
Member

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

act-observability-squad AKS az aks/acs/openshift Auto-Assign Auto assign by bot X Engineering Agent Reviewed Pull request reviewed by X Engineering Agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

az aks get-credentials fails with Error running kubelogin: [Errno 2] No such file or directory: '' despite kubelogin correctly installed and on PATH

4 participants