feat(math): add two negabinary numbers#198
Open
BrianLusina wants to merge 2 commits into
Open
Conversation
Contributor
📝 WalkthroughWalkthroughAdds a new ChangesNegabinary Addition Module
Directory Index Corrections and Additions
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pymath/adding_two_negabinary_numbers/README.md`:
- Around line 5-7: The README.md file in the
pymath/adding_two_negabinary_numbers directory has grammar and punctuation
issues in lines 5-7 that create ambiguity in the input format description. Fix
the redundant and awkwardly-phrased "format: as an array" construct on line 5
by removing the colon and extra space, and correct the confusing "array, format"
phrase on line 7 by removing the comma. The sentences should flow more naturally
while clearly describing that the input numbers are provided as arrays of 0s and
1s from most significant to least significant bit.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1bf1b73e-9af3-4035-93a7-cf085cf885e4
📒 Files selected for processing (4)
DIRECTORY.mdpymath/adding_two_negabinary_numbers/README.mdpymath/adding_two_negabinary_numbers/__init__.pypymath/adding_two_negabinary_numbers/test_add_two_negabinary_numbers.py
Comment on lines
+5
to
+7
| Each number is given in array format: as an array of 0s and 1s, from most significant bit to least significant bit. | ||
| For example, arr = [1,1,0,1] represents the number (-2)^3 + (-2)^2 + (-2)^0 = -3. A number arr in array, format is also | ||
| guaranteed to have no leading zeros: either arr == [0] or arr[0] == 1. |
Contributor
There was a problem hiding this comment.
Fix the input-format sentence to avoid ambiguity.
Line 5 through Line 7 have grammar/punctuation issues ("format: as an array" and "array, format") that make the input contract harder to parse.
Suggested patch
-Each number is given in array format: as an array of 0s and 1s, from most significant bit to least significant bit.
-For example, arr = [1,1,0,1] represents the number (-2)^3 + (-2)^2 + (-2)^0 = -3. A number arr in array, format is also
-guaranteed to have no leading zeros: either arr == [0] or arr[0] == 1.
+Each number is given in array format as an array of 0s and 1s, from the most significant bit to the least significant bit.
+For example, arr = [1,1,0,1] represents the number (-2)^3 + (-2)^2 + (-2)^0 = -3.
+An array-format number is guaranteed to have no leading zeros: either arr == [0] or arr[0] == 1.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| Each number is given in array format: as an array of 0s and 1s, from most significant bit to least significant bit. | |
| For example, arr = [1,1,0,1] represents the number (-2)^3 + (-2)^2 + (-2)^0 = -3. A number arr in array, format is also | |
| guaranteed to have no leading zeros: either arr == [0] or arr[0] == 1. | |
| Each number is given in array format as an array of 0s and 1s, from the most significant bit to the least significant bit. | |
| For example, arr = [1,1,0,1] represents the number (-2)^3 + (-2)^2 + (-2)^0 = -3. | |
| An array-format number is guaranteed to have no leading zeros: either arr == [0] or arr[0] == 1. |
🧰 Tools
🪛 LanguageTool
[grammar] ~5-~5: A determiner may be missing.
Context: ...0s and 1s, from most significant bit to least significant bit. For example, arr = [1...
(THE_SUPERLATIVE)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pymath/adding_two_negabinary_numbers/README.md` around lines 5 - 7, The
README.md file in the pymath/adding_two_negabinary_numbers directory has grammar
and punctuation issues in lines 5-7 that create ambiguity in the input format
description. Fix the redundant and awkwardly-phrased "format: as an array"
construct on line 5 by removing the colon and extra space, and correct the
confusing "array, format" phrase on line 7 by removing the comma. The sentences
should flow more naturally while clearly describing that the input numbers are
provided as arrays of 0s and 1s from most significant to least significant bit.
Source: Linters/SAST tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Add two negabinary numbers
Checklist:
Fixes: #{$ISSUE_NO}.Summary by CodeRabbit
Release Notes
New Features
Documentation
Tests