[FIX] Incomplete runs must not report pass (#1177) - #1179
Open
aryanorastar wants to merge 1 commit into
Open
Conversation
aryanorastar
requested review from
canihavesomecoffee and
thealphadollar
as code owners
August 16, 2026 04:50
aryanorastar
force-pushed
the
fix/1177-partial-run-false-pass
branch
from
August 16, 2026 05:29
956e4dc to
e05382f
Compare
Completed runs that only report a subset of configured regression tests were marked pass whenever that fragment was green. Compare reported TestResult IDs against the run's expected sample set (same rule as summary totals) and return error when any are missing.
aryanorastar
force-pushed
the
fix/1177-partial-run-false-pass
branch
from
August 16, 2026 05:59
e05382f to
154c41a
Compare
Author
|
Rebased onto current |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
passafter executing almost none of its samples #1177:_check_completed_run_statusonly inspected existingTestResultrows, so a completed run that executed 1 of N samples could still reportpasswhen that fragment was green./runs/{id}/summarytotals via sharedexpected_regression_ids).error(same class as zero results). Existing fail/pass checks still apply when the suite is complete.Test plan
nose2 tests.api.test_services_status(20 tests OK), including newtest_derive_run_status_completed_partial_results_is_errorCustomizedTestso they remain meaningful under the completeness check