Skip to content

[ENG-11519] 400 Error Editing CEDAR Metadata After Initial Save in Collection Submission #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adlius merged 1 commit into from
Jun 30, 2026
Merged

[ENG-11519] 400 Error Editing CEDAR Metadata After Initial Save in Collection Submission #1027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions ...onents/add-to-collection/collection-metadata-step/collection-metadata-step.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,16 @@
<div class="flex flex-column gap-4 w-full">
<h3>{{ 'collections.addToCollection.collectionMetadata' | translate }}</h3>

@if (!isDisabled() && stepperActiveValue() !== targetStepValue()) {
@if (!isDisabled() && !isStepActive()) {
@if (collectionMetadataSaved()) {
@if (isCedarMode()) {
@if (cedarTemplate()) {
@let cedarTpl = cedarTemplate();

@if (cedarTpl) {
<cedar-artifact-viewer
#cedarViewer
[config]="cedarViewerConfig"
[templateObject]="cedarTemplate()!.attributes.template"
[instanceObject]="cedarFormData()"

@adlius adlius Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't we need the instanceObject? I thought we need this to render the form?

@nsemets nsemets Jun 30, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instanceObject is still required for the viewer to show saved data. We moved viewer hydration from template-only to the mount effect. The editor form still uses [metadata]="cedarFormData()"

[templateObject]="cedarTpl.attributes.template"
></cedar-artifact-viewer>
}
} @else {
Expand Down Expand Up @@ -45,19 +46,23 @@ <h3>{{ 'collections.addToCollection.collectionMetadata' | translate }}</h3>
</p-step>

<p-step-panel [value]="targetStepValue()" class="p-0">
<ng-template class="m-0" #content let-activateCallback="activateCallback">
<ng-template #content>
@if (isCedarMode()) {
@if (cedarTemplate()) {
<div class="cedar-editor-container mt-3">
<cedar-embeddable-editor
#cedarEditor
[config]="cedarConfig"
[templateObject]="cedarTemplate()!.attributes.template"
[metadata]="cedarFormData()"
(change)="onCedarChange($event)"
(keyup)="onCedarChange($event)"
></cedar-embeddable-editor>
</div>
@let cedarTpl = cedarTemplate();

@if (cedarTpl) {
@if (isStepActive()) {
<div class="cedar-editor-container mt-3">
<cedar-embeddable-editor
#cedarEditor
[config]="cedarConfig"
[templateObject]="cedarTpl.attributes.template"
[metadata]="cedarFormData()"
(change)="onCedarChange($event)"
(keyup)="onCedarChange($event)"
></cedar-embeddable-editor>
</div>
}

<div class="flex justify-content-end gap-3 mt-4">
<p-button
Expand Down
Loading
Loading