Fix: add depth check to prevent stack overflow in cJSON_Utils (#995) - #1064
Open
tung515 wants to merge 1 commit into
Open
Fix: add depth check to prevent stack overflow in cJSON_Utils (#995)#1064tung515 wants to merge 1 commit into
tung515 wants to merge 1 commit into
Conversation
…veGamble#995) - Add CJSON_NESTING_LIMIT depth check to merge_patch, generate_merge_patch, and compare_json. - Prevent stack exhaustion when processing deeply nested JSON structures. - Add unit tests in misc_utils_tests to verify safety against deep recursion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the stack overflow vulnerability reported in #995 caused by uncontrolled recursion when processing deeply nested JSON objects in
cJSON_Utils.It follows the same recursion depth bounding pattern previously introduced in #984 by enforcing
CJSON_NESTING_LIMIT.Changes
CJSON_NESTING_LIMITdepth checks tomerge_patch,generate_merge_patch, andcompare_jsonto safely return failure on deeply nested inputs.tests/misc_utils_tests.cto verify thatcJSONUtils_MergePatchandcJSONUtils_GenerateMergePatchreject deeply nested structures safely.Related Issue
Fixes #995