Remove the redundant table-wide file cleanup from the manage-files view - #15836
Open
svader0 wants to merge 1 commit into
Open
Remove the redundant table-wide file cleanup from the manage-files view#15836svader0 wants to merge 1 commit into
svader0 wants to merge 1 commit into
Conversation
Cleanup of files whose parent object is deleted has been handled by the delete signals added in DefectDojo#13028, so the table-wide scan this view ran after every save is redundant.
|
This pull request contains a critical finding where the sensitive file 'dojo/views.py' was modified by an unauthorized author, 'svader0'.
🔴 Configured Sensitive Codepath Modified by Non-Allowed Author in
|
| Vulnerability | Configured Sensitive Codepath Modified by Non-Allowed Author |
|---|---|
| Description | File 'dojo/views.py' matches configured sensitive codepath pattern 'dojo/views.py' and was modified by 'svader0' (commit 376aeca) who is not in the allowed authors list. |
We've notified @mtesauro.
Comment to provide feedback on these findings.
Report false positive: @dryrunsecurity fp [FINDING ID] [FEEDBACK]
Report low-impact: @dryrunsecurity nit [FINDING ID] [FEEDBACK]
Example: @dryrunsecurity fp drs_90eda195 This code is not user-facing
All finding details can be found in the DryRun Security Dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes an inline cleanup step from the manage-files view. After every successful save the view scanned the whole
FileUploadtable and deleted any row that was not attached to an object.That scan is no longer needed. Cleanup of files whose parent object is deleted has been handled by the delete signals added in #13028, and the backlog was cleared by migration
0242_file_upload_cleanupat the same time.Adds a regression test that a file outside the object being edited is left alone.
No functional change for correctly-permissioned users.