Fix unstfu - #9443
Open
rustyrussell wants to merge 2 commits into
Open
Conversation
added 2 commits
August 21, 2026 14:11
While quiescing (STFU), handle_master_request_later queues outgoing HTLC updates (OFFER/FULFILL/FAIL) and fee/block updates on peer->update_queue, but no code path ever dequeued it. Messages were lost permanently when quiescence ended. Fix by moving any pending messages onto from_master when end_stfu_mode runs; the main loop drains from_master via req_in. Changelog-Fixed: channeld: risk of force close if we settle an HTLC during splice STFU.
Better describes its purpose: messages deferred while quiescing (STFU).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report filed that we don't properly restore commands when exiting STFU. Worst case, this could cause a force close.