DDI Export Cleanup - #12642
Merged
pdurbin merged 6 commits intoAug 27, 2026
Merged
DDI Export Cleanup#12642
Conversation
pdurbin
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
pdurbin
reviewed
Aug 25, 2026
Member
Author
|
This test fail is gdcc/dataverse-jsf-tests#1 - not related to the PR. |
Member
Author
|
And it passed the next time. |
pdurbin
approved these changes
Aug 25, 2026
pdurbin
left a comment
pdurbin
left a comment
Member
There was a problem hiding this comment.
We went over this during tech hours this morning. The changes make sense. Tests are passing. Approved.
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
cmbz
added
FY27 Sprint 4
github-project-automation
Bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The DDI Export API was making unnecessary db calls (to find filemetadata entries that are already associated with the loaded datafile object). This PR refactors to remove those calls and remove some unused methods (from ~2014) related to exporting for Datasets or individual variables. It also standardized error reporting - sending 403 instead of 400 when users don't have permission to view the file.
Which issue(s) this PR closes:
Special notes for your reviewer: Also updates a deprecated new Long() call that my IDE flagged and removes a redundant Content-disposition header.
Suggestions on how to test this: Regression test the datafile/{fileId}/metadata/ddi and /api/access/datafile/bundle/$id apis with just a file id and with either a null filemetadata - api (should get the latest published or draft result depending on user perms) or a supplied filemetadata id (should again be limited to a version you can access).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: