fix(config): allow disabling FEC by setting fec_percentage=0 (previously this was treated as 20) - #5454
Open
andygrundman wants to merge 1 commit into
Open
Conversation
…sly this was treated as 20)
|
ReenigneArcher
requested changes
Jul 27, 2026
Member
There was a problem hiding this comment.
Also needs updates to the following:
Sunshine/docs/configuration.md
Line 1984 in 25c3f0b
- (should change type from text to number and add min/max)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
fec_percentage was mistakenly defined as a value between 1 and 255, preventing it from being disabled with 0. This change defines it as 0-100 as you would expect from the name.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.