Add scoped OpenSecret EIF approval checks - #905
Merged
Conversation
Separate explicit PCR approval edits from EIF build-input routing. Compare dev and prod on approval-changing PRs and relevant master changes without requiring routine backend PRs to update approvals. Add read-only ARM64 build/comparison tooling, failure-path regression tests, and operational guidance preserving manual signing and publication. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Separate backend source validation from deployment-approval measurement parity.
ubuntu-24.04-armdev/prod EIF comparison workflow with independently reported matrix results.eif) and actual edits to the four approved dev/prod PCR JSON files (pcr_approvals). Validate the complete classifier output before exposing it to callers.Trigger policy
An indeterminate PR diff fails routing explicitly instead of inventing an approval edit. Master routing uncertainty conservatively enables comparisons. Existing Rust, Nix, SDK integration, audit, and signed-history validation remain separate.
Safety and scope
contents: read, no persisted checkout credentials, no signing/deployment credentials or artifact uploads.resultlink.Validation
nix flake check --no-update-lock-file --print-build-logs: all 10 root checks passed on Linux ARM64.bash -n scripts/ci/check_opensecret_eif.sh, and Git whitespace checks passed.Other host platforms and actual hosted ARM64 EIF execution remain unverified. This PR intentionally does not select its own EIF jobs because it changes no PCR approvals; relevant master changes will select them after merge. A successful CI comparison does not authorize deployment or prove that canonical and legacy public PCR endpoints are synchronized.