Restore scoped OpenSecret EIF caches - #906
Merged
Merged
Conversation
Restore FlakeHub caching for trusted master builds and warm the GitHub cache for unprivileged PR checks without extending the build timeout. Add cache permission and routing regressions and cold-run guidance. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on #905 to restore the missing EIF binary-cache setup without granting OIDC to PR code or extending the timeout.
id-token: write.diff-store: true, so substituted paths also warm the default-branch cache for unprivileged checks.Root cause
Both EIF jobs in master run 34563284787 timed out while cold-building the custom Linux 6.12.101 kernel. They fetched only from cache.nixos.org. The legacy workflow had fetched the identical kernel output from FlakeHub. Warm local builds and intentionally skipped PR EIF checks did not reveal this regression.
Validation
aarch64-linuxNix checks passed with credential variables excluded; other systems were omitted.git diff --checkpassed. Verified unchanged approval/lockfile hashes, protected-file metadata, dependency pins, saved EIF hashes, and dev/prod output selection. Output evaluation is not a new EIF build.Hosted verification still required
FlakeHub cache access is repository/organization-scoped. This change does not grant Maple access to legacy OpenSecretCloud cache entries. A fresh trusted-master ARM64 run must confirm authentication, actual custom-kernel substitution, timing, cache warming, and eventual PCR comparison. Then verify unprivileged reuse of the warmed GitHub cache. Cache-access or population work may require a separate operator checkpoint.
This PR does not edit approved PCR JSON, so its EIF comparisons should intentionally skip. Ordinary PR CI and local tests do not establish restored hosted build times. Expected mismatches against the existing approvals must remain visible; do not sign or update approvals to clear CI. No merge, manual workflow dispatch, cache-access grant, PCR publication, or deployment is part of this PR creation.