MDEV-22991 Support SSL over named pipes - #5589
Open
vaintroub wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements support for using SSL/TLS over Windows named-pipe connections by relaxing the historical “no SSL over named pipes” behavior and adding regression tests to validate both encrypted and unencrypted named-pipe connections.
Changes:
- Gate disabling of
CLIENT_SSLon named-pipe connections based on server capability/version rather than unconditionally disabling it. - Update the Windows mariabackup named-pipe auth-plugin test to require SSL and to run mariabackup with
--ssl. - Add a new MTR test (
named_pipe_ssl) covering named-pipe connections with and without SSL, including an account withREQUIRE SUBJECT.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sql-common/client.c | Allows SSL over named pipes when connecting to servers that support it; otherwise disables SSL for named-pipe transport. |
| mysql-test/suite/mariabackup/auth_plugin_win.test | Adjusts the named-pipe auth plugin test to require SSL and run mariabackup using SSL. |
| mysql-test/suite/mariabackup/auth_plugin_win.result | Updates expected output for the changed user creation/grant statements. |
| mysql-test/suite/mariabackup/auth_plugin_win.opt | Adds server startup option(s) for the test run. |
| mysql-test/main/named_pipe_ssl.test | Adds a new Windows-only regression test for SSL over named pipes. |
| mysql-test/main/named_pipe_ssl.result | Adds expected output for the new named-pipe SSL test. |
| mysql-test/main/named_pipe_ssl.opt | Enables named-pipe transport for the new test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+2040
to
+2043
| return mysql->server_version && | ||
| (strstr(mysql->server_version, "MariaDB") || | ||
| strstr(mysql->server_version, "-maria-")) && | ||
| mysql_get_server_version(mysql) >= 130100; |
| CREATE USER pipe_ssl_user@localhost REQUIRE SUBJECT '/C=FI/ST=Helsinki/L=Helsinki/O=MariaDB/CN=client'; | ||
|
|
||
| --echo # Client connection without SSL over a named pipe | ||
| --exec $MYSQL --protocol=pipe --user=root --skip-ssl -e "SELECT VARIABLE_VALUE <> '' AS have_ssl FROM INFORMATION_SCHEMA.SESSION_STATUS WHERE VARIABLE_NAME='Ssl_cipher'" 2>&1 |
vaintroub
force-pushed
the
main-MDEV-22991
branch
4 times, most recently
from
August 24, 2026 19:26
50e3b19 to
24b89bc
Compare
vaintroub
force-pushed
the
main-MDEV-22991
branch
from
August 24, 2026 20:51
24b89bc to
e34d87e
Compare
vaintroub
force-pushed
the
main-MDEV-22991
branch
from
August 24, 2026 21:37
e34d87e to
775069f
Compare
vaintroub
force-pushed
the
main-MDEV-22991
branch
from
August 24, 2026 21:40
775069f to
a387ddd
Compare
vaintroub
force-pushed
the
main-MDEV-22991
branch
from
August 24, 2026 22:28
a387ddd to
5cc33ae
Compare
Update libmariadb, to remove named pipe SSL check. Update client.c to remove that check as well. Add MTR test for named pipe + SSL: - for Connector/C client, new test named_pipe_ssl - for in-server clent, run mariabackup with user created as "IDENTIFIED WITH named_pipe REQUIRE SSL"
vaintroub
force-pushed
the
main-MDEV-22991
branch
from
August 25, 2026 09:27
5cc33ae to
da8bf47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update libmariadb, to remove named pipe SSL check. Update client.c to remove that check as well.
Add MTR test for named pipe + SSL: