Skip to content

πŸ› reject failed stopword downloads - #3797

Open
ump45nose wants to merge 1 commit into
ModelEngine-Group:developfrom
ump45nose:fix/stopwords-http-errors
Open

πŸ› reject failed stopword downloads#3797
ump45nose wants to merge 1 commit into
ModelEngine-Group:developfrom
ump45nose:fix/stopwords-http-errors

Conversation

@ump45nose

Copy link
Copy Markdown

Summary

  • reject non-success HTTP responses before writing the stopword file
  • avoid treating a short 404/500 response body as a valid stopword list
  • add a focused regression test that verifies an HTTP error returns False and leaves no file

Validation

  • direct fail-before/pass-after mocked HTTP reproduction
  • pytest -q test/sdk/core/nlp/test_stopwords.py β€” 1 passed
  • Ruff check and format check on both changed files
  • git diff --cached --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant