Skip to content

fix: soften distorted Force Surge soundtrack - #625

Closed
RowletCC wants to merge 3 commits into
NextCommunity:mainfrom
RowletCC:fix-force-surge-sound-317-v2
Closed

RowletCC wants to merge 3 commits into
NextCommunity:mainfrom
RowletCC:fix-force-surge-sound-317-v2

Conversation

@RowletCC

Copy link
Copy Markdown
Contributor

Fixes #317.

The Force Surge soundtrack layered three oscillators at a 0.6 master gain, so the combined waveform could overdrive the compressor and sound harsh. This lowers the stack to 0.15 per oscillator, uses a sine bass in place of the buzzy sawtooth, and eases the compressor settings while retaining the existing eight-second swell and cleanup.

Validation: node --check src/assets/js/script.js and git diff --check pass. This changes only the Force Surge audio graph; the visual effect and XP behavior are untouched.

@deepsource-io

deepsource-io Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 3221bab...d9f1a50 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Oct 3, 2026 3:07a.m. Review ↗
Secrets Oct 3, 2026 3:07a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@RowletCC
RowletCC force-pushed the fix-force-surge-sound-317-v2 branch from 9ca9a1b to 3b126e8 Compare September 26, 2026 11:16
@RowletCC
RowletCC force-pushed the fix-force-surge-sound-317-v2 branch from 3b126e8 to 35cb698 Compare September 26, 2026 11:19
@jbampton jbampton added this to the Hacktoberfest 2026 milestone Oct 3, 2026
@jbampton jbampton self-assigned this Oct 3, 2026
@jbampton jbampton added good first issue Good for newcomers javascript labels Oct 3, 2026

@jbampton jbampton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is really not much difference in sound.

I was wanting something a bit more fantastic

Thanks going to close this PR.

@jbampton jbampton closed this Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Fix the "Force Surge" sound effects

3 participants