Repository navigation
Conversation
When the Location of a Repair Order is a Virtual Location (no Warehouse), the temporary Location/Type could not be deleted resulting in the error: > psycopg2.errors.NotNullViolation: null value in column "location_dest_id" of relation "repair_order" violates not-null > constraint CONTEXT: SQL statement "UPDATE ONLY "public"."repair_order" SET "location_dest_id" = NULL WHERE $1 OPERATOR(pg_catalog.=) "location_dest_id"" Archive and keep the temporary Location/Type if that happens.
OCA-git-bot
added
mod:openupgrade_scripts
Author
|
@FranciscoBigWings @pleirb you faced the linked issue, would you like to have a look? Thanks! |
HekkiMelody
approved these changes
Sep 15, 2026
HekkiMelody
left a comment
HekkiMelody
left a comment
There was a problem hiding this comment.
Code review, LGTM.
Also, tested on a migration that had this problem.
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix!
Instead of keeping and archiving the temporary records, could we add a fallback matching by company_id for repair orders where location_id.warehouse_id is empty? That ensures all orders get valid picking types and allows deleting the temp records completely.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5474.
When the Location of a Repair Order is a Virtual Location (no Warehouse), the temporary Location/Type could not be deleted resulting in the error:
Archive and keep the temporary Location/Type if that happens.