Fix lambdas executing procedures with the wrong thread - #195
Open
the-can-of-soup wants to merge 3 commits into
Open
Fix lambdas executing procedures with the wrong thread#195the-can-of-soup wants to merge 3 commits into
the-can-of-soup wants to merge 3 commits into
Conversation
Author
|
I have tested and confirmed that this pull request fixes #194. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
#194
Proposed Changes
Stores references to procedure factories after a thread finishes compiling, and makes the Lambda extension use these factories to execute procedures in the proper thread.
Reason for Changes
Without a fix, lambdas could cause unpredictable execution behavior with custom blocks.
I STILL cannot figure out how to get a local PenguinMod instance running, so I have been unable to test this. Would appreciate if someone else could. An example to test with is uploaded in the Discord bug reports post.Edit: I finally got it working! I have tested and confirmed that this pull request would fix the bug if merged (compare with the example output images in #194):