Conversation
WyattBlue
force-pushed
the
patch
branch
3 times, most recently
from
August 18, 2026 04:20
48a81a9 to
9472d12
Compare
WyattBlue
changed the title
They reached only `avformat_find_stream_info()`, and only for formats
that expose their streams before it runs: anything else raised, so MPEG
and friends could never use them. Output containers rejected them
outright, pointing at `add_stream(options=)`. Type hints were wrong
since they were added, yet zero people complained.
`options` still reaches every stream at probe time,
`stream.codec_context.options` covers one stream and works on every
format, and add_stream(options=) covers writing. Object sizes:
Container 184 -> 176
InputContainer 184 -> 176
OutputContainer 208 -> 200
Also group Container's fields by kind and declare `name` as str.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.