BUG: evaluate parachute triggers once per time node (#1086) - #1121
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1121 +/- ##
===========================================
+ Coverage 83.53% 83.61% +0.08%
===========================================
Files 130 130
Lines 17086 17072 -14
===========================================
+ Hits 14273 14275 +2
+ Misses 2813 2797 -16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I ran the same never-deploying 10 Hz trigger on current
This confirms that the duplicate path was evaluating the trigger and appending pressure data twice at each node. The head keeps one evaluation and one pressure row per node. The committed regression file also passes independently: Environment: Python 3.12.6; NumPy 2.5.2; pytest 9.1.1; macOS 26.5.2 arm64. |
Remove the duplicate inline parachute loop in Flight.__simulate; keep only __check_and_handle_parachute_triggers.
d062c37 to
6e5aee7
Compare
Pull request type
Checklist
black rocketpy/ tests//make lint) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.md— no action needed; an LLM workflow auto-updates it after mergeCurrent behavior
Each time node evaluated parachute triggers twice: an inline loop in
Flight.__simulateand again in__check_and_handle_parachute_triggers.Fixes #1086
New behavior
The inline loop is removed; only
__check_and_handle_parachute_triggersruns per node. Regression test asserts one call per sampled height.Breaking change
Additional information
Focused unit tests added/extended; full slow suite not run in this contribution pass.