ENH: compute rocket static margin lazily (#780) - #1135
Open
thatrandomasiandev wants to merge 2 commits into
Open
ENH: compute rocket static margin lazily (#780)#1135thatrandomasiandev wants to merge 2 commits into
thatrandomasiandev wants to merge 2 commits into
Conversation
Reformat the static margin source lambda. No behaviour change: the _csys factor stays inside the lambda body, applied to the result. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1135 +/- ##
===========================================
+ Coverage 82.18% 84.33% +2.15%
===========================================
Files 122 130 +8
Lines 16355 17265 +910
===========================================
+ Hits 13441 14561 +1120
+ Misses 2914 2704 -210 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rocket.static_marginlazily: a dirty flag is set when geometry/mass/surfaces change; the Function is rebuilt (includingset_discrete) only on first access or an explicitevaluate_static_margin()call.add_motorandadd_surfacesinvalidate instead of eagerly rebuilding; public API (rocket.static_marginas a Function) is unchanged.Test plan
test_static_margin_lazy_until_accessed— SM not discretized until accessed after adding a surfacetest_static_margin_rebuilds_after_adding_surface— adding a surface invalidates; access rebuilds oncetests/unit/rocket/test_rocket.py+tests/integration/test_rocket.py(77 passed)