Skip to content

ENH: list NOAA atmosphere datasets and fetch latest (#660) - #1136

Open
thatrandomasiandev wants to merge 1 commit into
RocketPy-Team:developfrom
thatrandomasiandev:enh/660-list-noaa-datasets
Open

ENH: list NOAA atmosphere datasets and fetch latest (#660)#1136
thatrandomasiandev wants to merge 1 commit into
RocketPy-Team:developfrom
thatrandomasiandev:enh/660-list-noaa-datasets

Conversation

@thatrandomasiandev

Copy link
Copy Markdown

Summary

  • Adds best-effort helpers to list NCEP atmosphere collections and per-collection run identifiers from the Unidata THREDDS catalogs RocketPy already uses for GFS/NAM/RAP/HRRR/AIGFS (list_noaa_atmosphere_datasets, list_noaa_dataset_identifiers).
  • Adds convenience APIs to resolve and open the latest collection run via OPeNDAP (get_latest_noaa_opendap_url, fetch_latest_noaa_dataset) without changing Environment.
  • Documents limitations: NOMADS OPeNDAP is retired, so discovery scrapes THREDDS XML catalogs (layout can change); “download” means opening the remote dataset handle (same pattern as existing fetchers), not writing a local GRIB file.

Fixes #660

Test plan

  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 python -m pytest tests/unit/environment/test_fetchers.py -q (25 passed; catalog/HTTP mocked, no live NOAA)

@Gui-FernandesBR
Gui-FernandesBR force-pushed the enh/660-list-noaa-datasets branch from a4a2466 to 9cbbc43 Compare August 14, 2026 00:06
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.25000% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.26%. Comparing base (e0ff281) to head (9cbbc43).
⚠️ Report is 53 commits behind head on develop.

Files with missing lines Patch % Lines
rocketpy/environment/fetchers/noaa_catalog.py 81.13% 30 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1136      +/-   ##
===========================================
+ Coverage    82.18%   83.26%   +1.08%     
===========================================
  Files          122      131       +9     
  Lines        16355    17232     +877     
===========================================
+ Hits         13441    14349     +908     
+ Misses        2914     2883      -31     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENH: List all the available datasets of NOAA's server. Easily download the latest dataset.

1 participant