ENH: Create ensembles from user-defined profiles - #1141
Merged
Gui-FernandesBR merged 3 commits intoAug 15, 2026
Merged
Conversation
| raise ValueError(f"Member {member} '{variable}' heights must be unique.") | ||
| return profile | ||
|
|
||
| def create_ensemble( # pylint: disable=too-many-branches,too-many-locals,too-many-statements |
Member
There was a problem hiding this comment.
could you please not disable the pylint rules? Instead, try to split the method into smaller ones
Suggested change
| def create_ensemble( # pylint: disable=too-many-branches,too-many-locals,too-many-statements | |
| def create_ensemble( |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1141 +/- ##
===========================================
+ Coverage 83.53% 84.24% +0.71%
===========================================
Files 130 130
Lines 17086 17256 +170
===========================================
+ Hits 14273 14538 +265
+ Misses 2813 2718 -95 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Gui-FernandesBR
force-pushed
the
codex/enh-environment-create-ensemble-604
branch
from
August 15, 2026 02:19
41d5d53 to
e576165
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #604.
Pull request type
Checklist
CHANGELOG.md— no action needed; an LLM workflow auto-updates it after mergeCurrent behavior
Environmentcan load ensemble weather files, but users cannot combine their own atmospheric profiles into the NetCDF layout expected by the ensemble loader.New behavior
Environment.create_ensembleaccepts two or more user-defined pressure, temperature, eastward-wind and northward-wind profiles for one location. It:type="Ensemble"anddictionary="GEFS".The loader now also reports a zero-hour interval for static datasets that contain one valid time.
Breaking change
Verification
pytest tests/unit/environment -q— 163 passed, 6 skippedruff check rocketpy/environment/environment.py rocketpy/environment/tools.py tests/unit/environment/test_environment.pypylint rocketpy/environment/environment.py rocketpy/environment/tools.py tests/unit/environment/test_environment.py— 10.00/10