TST: cover controller behavior and reporting - #1152
Merged
Gui-FernandesBR merged 1 commit intoAug 14, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1152 +/- ##
===========================================
+ Coverage 82.18% 83.45% +1.26%
===========================================
Files 122 130 +8
Lines 16355 17082 +727
===========================================
+ Hits 13441 14255 +814
+ Misses 2914 2827 -87 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ting-hong-shieh
marked this pull request as ready for review
August 14, 2026 03:22
Gui-FernandesBR
approved these changes
Aug 14, 2026
Gui-FernandesBR
left a comment
Member
There was a problem hiding this comment.
does it really increase the test coverage? How many lines?
Gui-FernandesBR
force-pushed
the
codex/test-controller-coverage
branch
from
August 14, 2026 10:06
5a20510 to
e174742
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add focused unit coverage for controller state handling, reporting, and non-pickle serialization. The tests exercise observable behavior and complement the existing Flight integration coverage; they do not change production code.
This is a small contribution toward #709.
Coverage
Both measurements used the same non-slow unit, integration, and acceptance suite, followed by the RocketPy doctests.
cb6106a717207dd8fc2dfe1446d80ff75022f21b5a205109a6989a569d20e8ec448eba8c71c6ae1erocketpy/control/controller.pyrocketpy/prints/controller_prints.pyrocketpypackageThe new tests cover 24 previously missed statements. They verify:
from_dict()receives an existing callable.Verification
The three PyVista animation tests were excluded locally because the first off-screen render terminated the local VTK process with a segmentation fault. The repository workflow already runs those three tests as a separate retrying step; the PR does not modify animation code.
Environment