Skip to content

Fix invalid feedback_system value in docfx.json - #11003

Open
ShreyasSar26 wants to merge 1 commit into
SharePoint:mainfrom
ShreyasSar26:fix-docfx-feedback-system
Open

Fix invalid feedback_system value in docfx.json#11003
ShreyasSar26 wants to merge 1 commit into
SharePoint:mainfrom
ShreyasSar26:fix-docfx-feedback-system

Conversation

@ShreyasSar26

Copy link
Copy Markdown
Contributor

Summary

Fixes the recurring OpenPublishing build warning on docs/docfx.json:

Invalid value for feedback_system: GitHub. The value must be Standard, OpenSource, or None.

GitHub is a deprecated value. This repo collects docs feedback through GitHub Issues (feedback_github_repo is set to SharePoint/sp-dev-docs), so the correct modern value is OpenSource, which preserves the existing GitHub-Issues feedback behavior while clearing the warning.

Change

  • docs/docfx.json line 45: "feedback_system": "GitHub""feedback_system": "OpenSource"

Not included (intentionally)

The build also reports two ms.subservice warnings on general-development/** and spfx/** (sharepoint-framework not valid with ms.service: sharepoint-online). Those are unrelated to this change and may be intentional, so I've left them for the SPFx doc owners to decide.

Testing

Single global-metadata value change; no content or link changes. Feedback widget continues to route to GitHub Issues via the existing feedback_github_repo.

The validator requires feedback_system to be Standard, OpenSource, or None. This repo uses GitHub Issues for docs feedback (feedback_github_repo is set), so OpenSource is the correct value and preserves current behavior while clearing the build warning.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@learn-build-service-prod

Copy link
Copy Markdown
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 2a0f46d:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/docfx.json ⚠️Warning Details

docs/docfx.json

  • Line 68, Column 59: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.subservice': 'sharepoint-framework' is not valid with 'ms.service' value 'sharepoint-online'.
  • Line 69, Column 44: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.subservice': 'sharepoint-framework' is not valid with 'ms.service' value 'sharepoint-online'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@andrewconnell

Copy link
Copy Markdown
Collaborator

This is a significant change that I'd prefer Vesa Juvonen (@VesaJuvonen) make the call on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:in-review Actively reviewing pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants