Repository navigation
Avoid duplicate inserts when updating check runs - #1506
Merged
Merged
Conversation
dongyingtao-shopify
approved these changes
Oct 7, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshing a check run that is already stored attempts an insert before falling back to an update. This produces a duplicate-key SQL error for an ordinary update, even when the refresh succeeds.
Look up existing runs first and update them directly. Create missing runs inside a savepoint; if another writer creates the same run after the lookup, use a locking read to find it and apply the update. This preserves commit scoping, validations, callbacks, and the existing stale-webhook refresh behavior while keeping enclosing transactions usable after an insert conflict.
Adds regression coverage for updates without SQL errors, identical GitHub IDs on different commits, and a simulated concurrent insert inside a transaction.
Validation: