test(lit-query/createQueriesController): add tests for function 'initialData', 'initialDataUpdatedAt', and 'select' in the placeholder before a client is available by sukvvon · Pull Request #11753 · TanStack/query

sukvvon · 2026-09-30T05:53:01Z

🎯 Changes

Add tests for the placeholder result of createQueriesController before a QueryClient is available:
- initialData and initialDataUpdatedAt given as functions are called, so the combined result has data: 'seed' and dataUpdatedAt: 1000
- select is applied to initialData, so the combined result is 'SEED'

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added coverage for combined query results before a query client is available, including function-valued initial data, update timestamps, and selected initial data.

…ialData', 'initialDataUpdatedAt', and 'select' in the placeholder before a client is available

nx-cloud · 2026-09-30T05:53:30Z

View your CI Pipeline Execution ↗ for commit eb4d4c9

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	2m 52s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-30 05:57:04 UTC

github-actions · 2026-09-30T05:54:10Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-09-30T05:55:15Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 525a7756-301c-453b-924d-e690c3aa0b58

📥 Commits

Reviewing files that changed from the base of the PR and between ee077ef and eb4d4c9.

📒 Files selected for processing (1)

packages/lit-query/src/__tests__/createQueriesController.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

Walkthrough

The change adds two tests for combined placeholder results before a query client is available. They check function-valued initialData and initialDataUpdatedAt, and verify that select transforms placeholder data before the combine callback returns it.

Changes

Placeholder query results

Layer / File(s)	Summary
Placeholder result handling `packages/lit-query/src/__tests__/createQueriesController.test.ts`	Two tests check the combined result before a query client is available. One checks function-valued `initialData` and `initialDataUpdatedAt`; the other checks that `select` transforms `initialData` before combining.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to eb4d4

This test-only change strengthens placeholder-result coverage without changing runtime behavior. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the added tests and the covered `initialData`, `initialDataUpdatedAt`, and `select` behavior. It is specific to the main change, although longer than necessary.
Description check	✅ Passed	The description includes the required Changes, Checklist, and Release Impact sections. It explains the test coverage, reports local testing, confirms AI policy compliance, and identifies the change as…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-09-30T05:56:14Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11753

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11753

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11753

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11753

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11753

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11753

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11753

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11753

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11753

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11753

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11753

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11753

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11753

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11753

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11753

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11753

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11753

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11753

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11753

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11753

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11753

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11753

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11753

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11753

commit: eb4d4c9

github-actions · 2026-09-30T05:56:24Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

test(lit-query/createQueriesController): add tests for function 'init…

eb4d4c9

…ialData', 'initialDataUpdatedAt', and 'select' in the placeholder before a client is available

sukvvon self-assigned this Sep 30, 2026

sukvvon merged commit cf871a8 into main Sep 30, 2026
9 checks passed

sukvvon deleted the test/lit-query-create-queries-controller-placeholder-initial-data branch September 30, 2026 06:30

Navigation Menu

Uh oh!

test(lit-query/createQueriesController): add tests for function 'initialData', 'initialDataUpdatedAt', and 'select' in the placeholder before a client is available - #11753

test(lit-query/createQueriesController): add tests for function 'initialData', 'initialDataUpdatedAt', and 'select' in the placeholder before a client is available#11753
sukvvon merged 1 commit into
mainfrom
test/lit-query-create-queries-controller-placeholder-initial-data

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Sep 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading