test(lit-query/createQueriesController): remove unnecessary 'as const' from 'queries' arrays and host fields by sukvvon · Pull Request #11754 · TanStack/query

sukvvon · 2026-09-30T07:13:01Z

🎯 Changes

Remove as const from the queries arrays passed to createQueriesController in createQueriesController.test.ts and createQueriesController.test-d.ts, and from the ids host fields. createQueriesController infers each query in the array without it, as useQueries does in react-query, and the type tests with toEqualTypeOf still pass.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Updated query controller test coverage to check result and initial-data type inference when query-option and ID arrays use their naturally inferred mutable types.
- Runtime test behavior and assertions are unchanged; this update does not change the app’s user-facing behavior.

…' from 'queries' arrays and host fields

coderabbitai · 2026-09-30T07:14:50Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 8fc8b67b-9f95-4f2d-9f1b-4cddecefd31f

📥 Commits

Reviewing files that changed from the base of the PR and between cf871a8 and 2b75fef.

📒 Files selected for processing (2)

packages/lit-query/src/__tests__/createQueriesController.test-d.ts
packages/lit-query/src/__tests__/createQueriesController.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

The lit-query controller tests remove as const from query-option and ID arrays. Type inference cases and runtime assertions remain in the test suite.

Changes

Mutable query array test coverage

Layer / File(s)	Summary
Test mutable query inputs `packages/lit-query/src/__tests__/createQueriesController.test-d.ts`, `packages/lit-query/src/__tests__/createQueriesController.test.ts`	Type inference and runtime tests use query-option or ID arrays without `as const`. Existing runtime assertions remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 2b75f

This change broadens lit-query test coverage for mutable arrays without changing runtime code. The type tests pass, and no material merge risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description includes all required template sections. It clearly explains the test-only changes, records the checklist items, and identifies the change as dev-only with no release impact.
Title check	✅ Passed	The title clearly identifies the test scope and the main change: removing unnecessary "as const" usage from query arrays and host fields.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-30T07:15:19Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

nx-cloud · 2026-09-30T07:15:29Z

View your CI Pipeline Execution ↗ for commit 2b75fef

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	2m 9s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-30 07:18:44 UTC

pkg-pr-new · 2026-09-30T07:16:10Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11754

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11754

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11754

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11754

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11754

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11754

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11754

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11754

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11754

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11754

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11754

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11754

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11754

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11754

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11754

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11754

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11754

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11754

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11754

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11754

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11754

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11754

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11754

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11754

commit: 2b75fef

github-actions · 2026-09-30T07:16:19Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

test(lit-query/createQueriesController): remove unnecessary 'as const…

2b75fef

…' from 'queries' arrays and host fields

sukvvon self-assigned this Sep 30, 2026

sukvvon merged commit 6fab4f4 into main Sep 30, 2026
9 checks passed

sukvvon deleted the test/lit-query-create-queries-controller-remove-as-const branch September 30, 2026 07:28

Navigation Menu

Uh oh!

test(lit-query/createQueriesController): remove unnecessary 'as const' from 'queries' arrays and host fields - #11754

test(lit-query/createQueriesController): remove unnecessary 'as const' from 'queries' arrays and host fields#11754
sukvvon merged 1 commit into
mainfrom
test/lit-query-create-queries-controller-remove-as-const

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Sep 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

github-actions Bot commented Sep 30, 2026

🚀 Changeset Version Preview

Uh oh!

nx-cloud Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading