test(lit-query/createInfiniteQueryController): assert that 'fetchPreviousPage' rejects when no client is available by sukvvon · Pull Request #11755 · TanStack/query

sukvvon · 2026-09-30T07:41:07Z

🎯 Changes

In the two tests that assert refetch() and fetchNextPage() of the infinite query controller reject with No QueryClient available when no client is available, also assert the same for fetchPreviousPage().

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added coverage confirming that requesting a previous page rejects when no query client is available, both before and after connecting without a provider.

…iousPage' rejects when no client is available

coderabbitai · 2026-09-30T07:42:38Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b91583ac-1ba2-4a38-9eab-3d848c2aa219

📥 Commits

Reviewing files that changed from the base of the PR and between 6fab4f4 and 478092b.

📒 Files selected for processing (1)

packages/lit-query/src/__tests__/createInfiniteQueryController.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

Walkthrough

Two tests for an infinite query controller now check that fetchPreviousPage() rejects with /No QueryClient available/ when no QueryClient is available.

Changes

Missing-client test coverage

Layer / File(s)	Summary
Missing-client rejection assertions `packages/lit-query/src/__tests__/createInfiniteQueryController.test.ts`	The pre-connect and connected-consumer tests assert that `fetchPreviousPage()` rejects with `/No QueryClient available/`.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 47809

This test-only change adds missing-client checks for previous-page fetching in both consumer states without changing runtime behavior. No PR-introduced merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 47809

The change affects 1 system.

Changed systems: packages/lit-query

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — packages/lit-query (library) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in packages/lit-query/src/tests/createInfiniteQueryController.test.ts: The pre-connect missing-client test now checks that fetchPreviousPage() rejects with /No QueryClient available/, alongside the existing refetch and next-page rejection checks.
observed — Modified behavior in packages/lit-query/src/tests/createInfiniteQueryController.test.ts: The connected-consumer test without a provider now also checks that fetchPreviousPage() rejects with /No QueryClient available/.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: adding a test assertion that fetchPreviousPage() rejects when no QueryClient is available.
Description check	✅ Passed	The description includes the required Changes, Checklist, and Release Impact sections. It explains the test changes, reports local testing, confirms policy compliance, and identifies the change as dev…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-09-30T07:43:05Z

View your CI Pipeline Execution ↗ for commit 478092b

Command	Status	Duration	Result
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 12s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-30 07:45:44 UTC

github-actions · 2026-09-30T07:43:41Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-09-30T07:45:37Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11755

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11755

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11755

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11755

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11755

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11755

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11755

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11755

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11755

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11755

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11755

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11755

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11755

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11755

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11755

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11755

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11755

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11755

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11755

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11755

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11755

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11755

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11755

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11755

commit: 478092b

github-actions · 2026-09-30T07:45:45Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

test(lit-query/createInfiniteQueryController): assert that 'fetchPrev…

478092b

…iousPage' rejects when no client is available

sukvvon self-assigned this Sep 30, 2026

sukvvon merged commit e7e7283 into main Sep 30, 2026
9 checks passed

sukvvon deleted the test/lit-query-create-infinite-query-controller-fetch-previous-page-missing-client branch September 30, 2026 07:48

Navigation Menu

Uh oh!

test(lit-query/createInfiniteQueryController): assert that 'fetchPreviousPage' rejects when no client is available - #11755

test(lit-query/createInfiniteQueryController): assert that 'fetchPreviousPage' rejects when no client is available#11755
sukvvon merged 1 commit into
mainfrom
test/lit-query-create-infinite-query-controller-fetch-previous-page-missing-client

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Sep 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Architecture Summary

Uh oh!

nx-cloud Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading