Skip to content

fix(sorts): raise ValueError for negative inputs in radix_sort (#14950) #14984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheRodzz wants to merge 1 commit into from
+10 −0
Closed

fix(sorts): raise ValueError for negative inputs in radix_sort (#14950) #14984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sorts/radix_sort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,17 @@ def radix_sort(list_of_ints: list[int]) -> list[int]:
True
>>> radix_sort([1,100,10,1000]) == sorted([1,100,10,1000])
True
>>> radix_sort([-1, 2, 3])
Traceback (most recent call last):
...
ValueError: All elements in list_of_ints must be non-negative integers
"""
if not list_of_ints:
return []

if any(i < 0 for i in list_of_ints):
raise ValueError("All elements in list_of_ints must be non-negative integers")

placement = 1
max_digit = max(list_of_ints)
while placement <= max_digit:
Expand Down
Loading