Skip to content

fix(sorts): raise ValueError for negative inputs in radix_sort (#14950) - #14986

Open
TheRodzz wants to merge 4 commits into
TheAlgorithms:masterfrom
TheRodzz:fix-radix-sort-negative-inputs
Open

fix(sorts): raise ValueError for negative inputs in radix_sort (#14950)#14986
TheRodzz wants to merge 4 commits into
TheAlgorithms:masterfrom
TheRodzz:fix-radix-sort-negative-inputs

Conversation

@TheRodzz

Copy link
Copy Markdown

Describe your change:

Fixes #14950

Adds validation to radix_sort() to raise a ValueError when negative integers are passed in list_of_ints (as radix sort only supports non-negative integers), and handles empty lists gracefully.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jul 31, 2026
@algorithms-keeper algorithms-keeper Bot added the merge conflicts Open a new PR or rebase on the latest commit label Jul 31, 2026
@TheRodzz

Copy link
Copy Markdown
Author

pre-commit.ci run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files merge conflicts Open a new PR or rebase on the latest commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sorts/radix_sort.py: radix_sort() does not raise exception for negative inputs

2 participants