Repository navigation
Exercise cache digest dependency discovery in the boot benchmark - #2745
Merged
Merged
Conversation
…g class reloading in the benchmark app and having each generated component render another.
joelhawksley
force-pushed
the
joelhawksley-boot-benchmark-component-renders
branch
from
October 23, 2026 19:52
d22f229 to
9c58676
Compare
joelhawksley
deleted the
joelhawksley-boot-benchmark-component-renders
branch
October 23, 2026 20:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The boot benchmark wasn't measuring cache digest computation:
CacheDigest.precompute!never ranThis pull request sets
cache_classes = trueinperformance/boot.rband makes every generated component render another one. Each component renders one other component in a shallow tree.Locally, with
PASSES=5, the boot ratio goes from 1.59 on main to 2.02 with #2741, so CI would now flag that regression.