Repository navigation
OptimizeInstructions: Do not remove abs of x * x or x / x without --fast-math - #9225
Merged
stevenfontanella merged 3 commits intoOct 20, 2026
Merged
Conversation
tamaroning
requested review from
stevenfontanella
and removed request for
a team
October 7, 2026 16:20
stevenfontanella
left a comment
stevenfontanella
left a comment
Member
There was a problem hiding this comment.
LGTM besides one nit
| ;; RUN: foreach %s %t wasm-opt --generate-global-effects --optimize-instructions --fast-math -all -S -o - \ | ||
| ;; RUN: | filecheck %s | ||
|
|
||
| ;; A test here uses abs(x * x) ==> x * x, which requires fast-math. |
Member
There was a problem hiding this comment.
nit: since only one test makes use of the fast-math assumption, can we change that test to instead do a different optimization that doesn't need it and remove fast-math from this test?
| (call $potent) | ||
| (call $potent) | ||
| ) | ||
| (ref.eq |
Member
There was a problem hiding this comment.
nit: can the callee just return an i32, and we use i32.eq here? That seems a little simpler and seems like it would also be optimized by OptimizeInstructions.
Contributor
Author
There was a problem hiding this comment.
Sorry for the delay. Done, thanks!
stevenfontanella
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9179