Repository navigation
Code Quality: Use ??= for empty array defaults in anchor support and duotone - #15354
shail-mehta wants to merge 2 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the empty-array initialization cleanup.
No open issues 🎉
What changed in this PR
Modernizes empty-array initialization in WordPress Core’s anchor support and duotone handling as part of the #65823 cleanup, with no behavior change.
Changes:
- Replaces two
! isset()guards with equivalent??=assignments. - Preserves empty-array defaults for unset or null values.
| File | Description |
|---|---|
src/wp-includes/class-wp-duotone.php |
Simplifies the editor styles array default in add_editor_settings(). |
src/wp-includes/block-supports/anchor.php |
Simplifies the block attributes array default for anchor support. |
Review effort: Balanced
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Trac ticket: #65823
Backports: WordPress/gutenberg#86119
What?
Replaces
! isset( … ) { … = array(); }empty-array guards with the null coalescing assignment operator (??=) in two Core files.Why?
$x ??= array()is equivalent to the longer! issetguard and matches the ongoing #65823 cleanup. These two spots were still using the old pattern (Gutenberg already covers the same changes).How?
src/wp-includes/block-supports/anchor.php:$block_type->attributes ??= array();src/wp-includes/class-wp-duotone.php:$settings['styles'] ??= array();inWP_Duotone::add_editor_settings()No behavior change.
Testing Instructions
# Confirm the diff is only ??= replacements: git diff origin/trunk -- src/wp-includes/block-supports/anchor.php src/wp-includes/class-wp-duotone.phpOptionally smoke-test block editor load with a duotone-capable block and an anchor-supporting block.
Use of AI Tools