Skip to content

Code Quality: Use ??= for empty array defaults in anchor support and duotone - #15354

Open
shail-mehta wants to merge 2 commits into
WordPress:trunkfrom
shail-mehta:code-quality/65823-null-coalescing-anchor-duotone
Open

shail-mehta wants to merge 2 commits into
WordPress:trunkfrom
shail-mehta:code-quality/65823-null-coalescing-anchor-duotone

Conversation

@shail-mehta

Copy link
Copy Markdown
Member

Trac ticket: #65823

Backports: WordPress/gutenberg#86119

What?

Replaces ! isset( … ) { … = array(); } empty-array guards with the null coalescing assignment operator (??=) in two Core files.

Why?

$x ??= array() is equivalent to the longer ! isset guard and matches the ongoing #65823 cleanup. These two spots were still using the old pattern (Gutenberg already covers the same changes).

How?

  • src/wp-includes/block-supports/anchor.php: $block_type->attributes ??= array();
  • src/wp-includes/class-wp-duotone.php: $settings['styles'] ??= array(); in WP_Duotone::add_editor_settings()

No behavior change.

Testing Instructions

# Confirm the diff is only ??= replacements:
git diff origin/trunk -- src/wp-includes/block-supports/anchor.php src/wp-includes/class-wp-duotone.php

Optionally smoke-test block editor load with a duotone-capable block and an anchor-supporting block.

Use of AI Tools

  • Cursor

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the empty-array initialization cleanup.

No open issues 🎉

What changed in this PR

Modernizes empty-array initialization in WordPress Core’s anchor support and duotone handling as part of the #65823 cleanup, with no behavior change.

Changes:

  • Replaces two ! isset() guards with equivalent ??= assignments.
  • Preserves empty-array defaults for unset or null values.
File Description
src/​wp-includes/​class-wp-duotone.php Simplifies the editor styles array default in add_editor_settings().
src/​wp-includes/​block-supports/​anchor.php Simplifies the block attributes array default for anchor support.

Review effort: Balanced

@shail-mehta
shail-mehta marked this pull request as ready for review November 2, 2026 09:00
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@Mamaduka
Mamaduka requested a review from Soean November 2, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants