feat(tools): track read completeness and guard the diff-view save path (S4b, #1375) - #1833

Closed

easonLiangWorldedtech wants to merge 104 commits into

Zoo-Code-Org:mainfrom

easonLiangWorldedtech:feat/fws-s4b-followups

Commits on Aug 27, 2026

feat(file-safety): atomic text publish primitive + safeWriteJson refactor (A4, #1375)
easonliang28
committed
a37dd24
feat(file-safety): add version token for the guarded-write path (A1, #1375)
easonliang28
committed
3dd8700
docs(file-safety): correct ino precision bounds in version token (A1, #1375)
easonliang28
committed
ba1332e
fix(file-safety): derive the version token from exact BigInt stats (A1, #1375)
easonliang28
committed
6813013
feat(task): per-task file observation registry (A2, #1375)
easonliang28
committed
588b95f
feat(tools): guarded write CAS core with per-path FIFO chain (S4a, #1375)
easonliang28
committed
7a25fc0
feat(tools): wire guarded writes into the diff-view save paths (S4b, #1375)
easonliang28
committed
68be264

Commits on Aug 28, 2026

fix(fws): observe the apply_patch hunk read for the guarded publish
easonliang28
committed
88c9352

Commits on Aug 30, 2026

chore(ci): empty commit — re-trigger CI and the CodeRabbit current-head review gate (no code change)
easonliang28
committed
e96df62

Commits on Sep 28, 2026

feat(tools): track read completeness and guard the diff-view save path (S4b, #1375)
easonLiangWorldedtech
committed
aafdd1c
test(tools): kill surviving mutants in the S4b completeness guards (S4b, #1375)
easonLiangWorldedtech
committed
70ad366
test(tools): pin the post-read stat options in the S4b preview tests (S4b, #1375)
easonLiangWorldedtech
committed
d8c5275
fix(tools): clean up a partial DACL dump left by a failed icacls save (S4b, #1375)
easonLiangWorldedtech
committed
786bd5c
fix(tools): address CR review round 1 - partial-read gate, post-publish refresh, dirty buffer, staging dir (S4b, #1375)
easonLiangWorldedtech
committed
7204ead
test(tools): kill the 18 preflight survivors from the T1-T5 fix round (S4b, #1375)
easonLiangWorldedtech
committed
34fcfcd
fix(tools): restructure the win32 DACL restore gate and close the last mutant holes (S4b, #1375)
easonLiangWorldedtech
committed
56b329a
test(tools): kill the last OptionalChaining mutant from the DACL restructure (S4b, #1375)
easonLiangWorldedtech
committed
dd15018
fix(tools): track the create-branch placeholder even over a prior observation (S4b, #1375)
easonLiangWorldedtech
committed
a49fdb5
test(tools): cover the create-branch task gate with a collected-task case (S4b, #1375)
easonLiangWorldedtech
committed
d037753
fix(tools): stat-match the create placeholder + fail-closed save cleanup (S4b, #1375)
easonLiangWorldedtech
committed
d8c34aa

Commits on Oct 2, 2026

Merge remote-tracking branch 'upstream/main' into feat/fws-s4b-followups
easonLiangWorldedtech
committed
90d6804
chore: re-trigger CodeRabbit re-review and label reconcile
easonLiangWorldedtech
committed
221eaed
chore: trigger CodeRabbit re-review (finding already addressed)
easonLiangWorldedtech
committed
db5b56d
Merge commit 'refs/shapes/upstream-main' into feat/fws-s4b-followups
easonLiangWorldedtech
committed
c76f95b
chore: trigger CodeRabbit re-review / label reconcile
easonLiangWorldedtech
committed
174b825

Commits on Oct 3, 2026

fix(s4b): give each self-staged write its own staging directory so a concurrent write cannot remove it
easonLiangWorldedtech
committed
32c7afe
fix(s4b): remove the staging directory when a self-staged write fails
easonLiangWorldedtech
committed
bc6f474
test(s4b): pin the per-write staging directory name shape so the uniqueness contract is tested
easonLiangWorldedtech
committed
ad04d2b
fix(s4b): publish in the document encoding, lock the resolved delete target, dispose the listener before the revert
easonLiangWorldedtech
committed
bf27716
fix(s4b): pass the tool's write kind through the diff-view save and publish with VS Code's codec

easonLiangWorldedtech
and
web-flow
committed
d1e4867
test(s4b): assert the codec's bytes reach the publish, not only that the codec ran
easonLiangWorldedtech
committed
133b985
fix(s4b): keep a partial read partial after an edit and count a clipped line as truncated
easonLiangWorldedtech
committed
31bd913
fix(s4b): keep the model's read completeness for apply_patch and separate clipping from omission
easonLiangWorldedtech
committed
1771fcc
fix(s4b): carry apply_patch completeness only on the version it was earned on
easonLiangWorldedtech
committed
b4ad010
fix(s4b): match the guard kind on the diff-view save and keep a clipped read's content
easonLiangWorldedtech
committed
a325bd2
test(s4b): assert the saved result on the diff-view save paths
easonLiangWorldedtech
committed
e018044
docs(s4b): bring the guard and registry headers in line with the shipped behavior
easonLiangWorldedtech
committed
f223547
docs(s4b): note the create exception in the guarded-write stale rule
easonLiangWorldedtech
committed
abd1a07
docs(s4b): name the token a later guarded write compares against
easonLiangWorldedtech
committed
2286f33
test(s4b): make the diff-view save and fsync-ordering tests assert what they claim
easonLiangWorldedtech
committed
7f24fe7
fix(s4b): do not save the document after the guarded publish
easonLiangWorldedtech
committed
9297464
fix(s4b): the diff-view preview is not a model read
easonLiangWorldedtech
committed
1b54313
fix(s4b): carry the source's completeness to a move destination
easonLiangWorldedtech
committed
04719af
fix(s4b): finish the rejected-create cleanup, guard the revert, and keep the target mode
easonLiangWorldedtech
committed
e765a4d
fix(s4b): scope the workbench revert to the intended document
easonLiangWorldedtech
committed
1bca6fc
fix(s4b): only remove the placeholder when the discard completed
easonLiangWorldedtech
committed
e0ce670
fix(s4b): probe the lock key the writer actually uses
easonLiangWorldedtech
committed
d113168
fix(s4b): never publish through a dangling symlink
easonLiangWorldedtech
committed
6142333
test(s4b): reset the focus the revert helper reads between tests
easonLiangWorldedtech
committed
002513e

Commits on Oct 4, 2026

fix(s4b): keep the liveness probe working for a dangling link
easonLiangWorldedtech
committed
ef1bd10
Merge upstream main (a077066538) into feat/fws-s4b-followups
easonLiangWorldedtech
committed
2e8598f
refactor(s4b): stay inside the changed-line cap
easonLiangWorldedtech
committed
52f5992
fix(s4b): follow the whole link chain when probing the writer's lock
easonLiangWorldedtech
committed
5eeaa39
chore: re-run CI after a flaky e2e-mock timeout
easonLiangWorldedtech
committed
986bac2
fix(s4b): bound the lock-key chain walk against a link cycle
easonLiangWorldedtech
committed
4b7fe7a
test(s4b): assert the cache result in the link-chain test
easonLiangWorldedtech
committed
2798f75
fix(s4b): keep the delete paths and the read view honest
easonLiangWorldedtech
committed
a8092db
refactor(s4b): keep reconcile's JSDoc immediately above reconcile
easonLiangWorldedtech
committed
e724bcb
Re-trigger review at the current head
easonLiangWorldedtech
committed
d0a61fa
Assert the unlink target in the delete() alias test
easonLiangWorldedtech
committed
85b4a2b
Make the link-cycle test actually run the cycle
easonLiangWorldedtech
committed
19e37b2
Adopt content that autosave already published instead of failing
easonLiangWorldedtech
committed
891b18a
Cover the adoption branches the gate flagged
easonLiangWorldedtech
committed
0660afc
Make the adoption check provably scoped to guard verdicts
easonLiangWorldedtech
committed
8e12e9f
Merge branch 'main' of https://github.com/Zoo-Code-Org/Zoo-Code into feat/fws-s4b-followups
easonLiangWorldedtech
committed
1ea64ba
Re-run the mutation gate on this PR's own delta

easonLiangWorldedtech
and
claude
committed
ac71b93
Drop the three duplicated adoption tests

easonLiangWorldedtech
and
claude
committed
01918b6

Commits on Oct 5, 2026

fix(file-safety): run the guard check and publish under the shared advisory lock
easonLiangWorldedtech
committed
53c9b76
test(file-safety): mock the shared advisory lock in specs that reach the guarded write
easonLiangWorldedtech
committed
425aed9
fix(file-safety): key the advisory lock to the resolved target and read the post-publish token under it
easonLiangWorldedtech
committed
69bf534
test(file-safety): keep the lock-key spec portable and type-clean
easonLiangWorldedtech
committed
a55720e
style(file-safety): format the lock-key spec
easonLiangWorldedtech
committed
e8d6e66
fix(file-safety): keep the resolution inside the protected block so the lock is released
easonLiangWorldedtech
committed
7624519
test(file-safety): exercise the ENOENT+symlink branch in the lock-key spec
easonLiangWorldedtech
committed
a5ec999
test(file-safety): assert the symlink branch the lock key depends on
easonLiangWorldedtech
committed
e14d72f
test(file-safety): reach the strict rejection through the ENOENT+symlink branch
easonLiangWorldedtech
committed
206703d
fix(file-safety): canonicalize the lock key when the target itself is not there yet
easonLiangWorldedtech
committed
35d94be
test(read-file): drop a no-op any cast and prune its suppression
easonLiangWorldedtech
committed
945460b
fix(editor): a rejected save closes only its own diff tab
easonLiangWorldedtech
committed
b0a78f4
test(task-persistence): canonicalize the directory in the realpath double
easonLiangWorldedtech
committed
b165482
test(task-persistence): assert the lock key against the canonical directory
easonLiangWorldedtech
committed
eb6fc68
test(task-persistence): make every realpath double canonicalize the directory
easonLiangWorldedtech
committed
f1a47df
fix(apply-patch): carry the source's completeness to the move destination before the publish
easonLiangWorldedtech
committed
11afee7
fix(file-safety): propagate a non-ENOENT stat failure in the mode-preservation path
easonLiangWorldedtech
committed
ce61546
fix(apply-patch): carry the source's completeness through the publish for a fresh destination
easonLiangWorldedtech
committed
12525c5
test(utils): clean up the lock-key spec's temp dirs and reset its doubles
easonLiangWorldedtech
committed
3704068
docs(test): put the canonicalization JSDoc on its function and cover a post-read stat rejection
easonLiangWorldedtech
committed
9c42789
fix(apply-patch): reject a partial source move onto an observed destination before changing state
easonLiangWorldedtech
committed
98b0277
fix(apply-patch): reject a partial-source move only when the destination still exists
easonLiangWorldedtech
committed
08f0fc8
fix(apply-patch): propagate a non-ENOENT destination access error before changing its observation
easonLiangWorldedtech
committed
303123b
test(diff-view): cover a post-read stat rejection during the preview
easonLiangWorldedtech
committed
9ba1e11
fix(apply-patch): make queued guarded writes cancellation-aware
easonLiangWorldedtech
committed
5d7c726
fix(diff-view): serialize the placeholder cleanup with the shared advisory lock
easonLiangWorldedtech
committed
ded6d14
fix(apply-patch): keep the model-facing guard path workspace-relative
easonLiangWorldedtech
committed
357e24e
fix(apply-patch): name the caller's path on a stale-version rejection and document the lock boundary
easonLiangWorldedtech
committed
bfb90a7
fix(diff-view): keep a reset inside the task whose save was rejected
easonLiangWorldedtech
committed
1b74c27
fix(diff-view): identify this provider's tab by URI, not by basename
easonLiangWorldedtech
committed
25cf13b
test(apply-patch): put the stale-path test inside the describe block
easonLiangWorldedtech
committed
59b650f
fix(diff-view): close only Zoo's own diff tab for this provider
easonLiangWorldedtech
committed
2656fd2
fix(safe-write): do not log the expected miss in the safety-net cleanup
easonLiangWorldedtech
committed
df793c8
fix(read-file): report clipping and truncation together
easonLiangWorldedtech
committed
0ba7af0
fix(diff-view): let one teardown path own a cancelled save
easonLiangWorldedtech
committed
f6d460b
fix(safe-write): report the partial state when a rollback also fails
easonLiangWorldedtech
committed
ddece31
fix(apply-patch): recheck cancellation before publication starts
easonLiangWorldedtech
committed
6768ccf