Conversation
collector/alerts/base.py sat at 27.78% coverage with no direct tests for get_threshold/get_threshold_async. Adds tests/alerts/test_alert_deriver_base.py covering sync/async policy_getter, disabled policy, missing policy, and the documented sync-context limitation (async getter in the sync get_threshold falls back to default). Fixes #311 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/alerts/test_alert_deriver_base.pycoveringAlertDeriver.get_thresholdandget_threshold_asyncincollector/alerts/base.py(was 27.78% covered, lines 44-50 and 68-74 were untested)get_threshold_async(awaited correctly)Test plan
ruff check .— all checks passedpytest -q tests/alerts/test_alert_deriver_base.py— 9 passedpytest -q -m 'not e2e'(full suite) — 3116 passed, 34 skipped, 46 deselectedFixes #311
🤖 Generated with Amplifier