Repository navigation
usb host bulk in support - #11479
usb host bulk in support#11479
Conversation
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Please rethink the API. Maybe look at async pyusb too.
# Conflicts: # locale/circuitpython.pot # ports/raspberrypi/boards/adafruit_fruit_jam/mpconfigboard.mk # shared-module/usb/core/Device.c
|
This is refactored in the latest commits to a new module |
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
A few API questions but overall it is getting close. Thanks!
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
I think you can fold the notion of ended into deinit. It's a little tricky with moving any remaining values to a VM allocated buffer but that way it'll get cleaned up automatically after the deinit() call. You can't use a port allocated buffer because it doesn't get GCed.
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Thanks! I think this is close. I would simplify things by making an explicit deinit work the same as a finalizer. The only way to get deinit but maintain the buffer is implicit deinit due to losing the device.
2 participants
Adds
start_bulk_in(),read_bulk_into(),stop_bulk_in(), andbulk_in_lost_packetstousb.core.DeviceThe
"No continuous capture running"error message is the only new one added. It could use"Interface must be started"instead if we want to re-use a an existing string that isn't as close of a fit.Only enabled and tested on the Fruit Jam with USB SDR devices.