fix: guard inert feature detection against undefined HTMLElement.prototype#10275
Open
mvanhorn wants to merge 1 commit into
Open
fix: guard inert feature detection against undefined HTMLElement.prototype#10275mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
snowystinger
approved these changes
Jun 30, 2026
snowystinger
left a comment
Member
There was a problem hiding this comment.
In general looks good, verified that the test broke before the fix and passes with it
| expect(() => require('../../src/overlays/ariaHideOutside')).not.toThrow(); | ||
| }); | ||
|
|
||
| it('does not throw at import time when HTMLElement is undefined (non-DOM SSR)', function () { |
Member
There was a problem hiding this comment.
when does this one happen?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10219
✅ Pull Request Checklist:
📝 Test Instructions:
The module-level
supportsInertdetection inpackages/react-aria/src/overlays/ariaHideOutside.tsevaluated'inert' in HTMLElement.prototypeafter only checking thatHTMLElementwas defined. In some bundler/SSR setups (reported with Next.js/Turbopack reloads)HTMLElementexists butHTMLElement.prototypeisundefined, so theinoperator threwTypeError: Cannot use 'in' operator to search for 'inert' in undefinedat import time.This adds a
HTMLElement.prototype != nullguard before theincheck. When the prototype is missing,supportsInertnow resolves tofalse, the same path used in environments without inert support, and the code falls back toaria-hidden. Behavior in a normal DOM is unchanged.To verify:
yarn jest packages/react-aria/test/overlays/ariaHideOutside.test.jspasses, including two new cases underariaHideOutside inert feature detectionthat import the module withHTMLElement.prototypeundefined and withHTMLElementundefined and assert no throw.inertpath.🧢 Your Project:
Personal open source contribution.