fix: breadcrumbs href undefined causing an empty string#10286
Open
snowystinger wants to merge 1 commit into
Open
fix: breadcrumbs href undefined causing an empty string#10286snowystinger wants to merge 1 commit into
snowystinger wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Noticed while debugging the Breadcrumbs chromatic story snapshot change. If you are on main and run
yarn chromatic, then go to the S2 Breadcrumb story, after it loads, it'll error with"Error: An empty string ("") was passed to the href attribute. To fix this, either do not render the element at all or pass null to href instead of an empty string."
This is because open link checks if a key in in the props but doesn't check if it's undefined value. In React, undefined in the props object is considered the same as the key not being present. So I've updated our check to match React behaviour.
The reason that it was an issue is because of this change https://github.com/adobe/react-spectrum/pull/7032/changes which now always calls useHref. However, it would return an empty string, and that was what was used.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: