fix: persist ACP session config in Codex threads#337
Open
gilbertl wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Session config was split between adapter memory and Codex thread state. Reasoning effort could revert after one turn, and agent mode could revert when the ACP worker restarted. AoE also restores Agent (full access) asynchronously after session/load, which exposed a second race: a queued first prompt could capture Agent mode, pause during skill refresh, then start with on-request approval even though full access had already been restored.
Codex 0.145 supports model, effort, approval policy, and sandbox policy in thread/settings/update. Persisting those values makes the Codex thread authoritative. Reading them back on resume restores the ACP picker state, and resolving the mode immediately before turn/start prevents stale prompt-preparation snapshots.
The legacy sessionId response is required by persistent ACP clients that validate session/new and session/load uniformly and cache the returned thread identifier for the next worker restart.
Fixes #336.
Test plan