fix: bound stdin closure during subprocess shutdown - #152
Open
Oscar-Williams wants to merge 1 commit into
Open
Oscar-Williams wants to merge 1 commit into
Oscar-Williams wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a child stops reading stdin with buffered input pending,
spawn_stdio_transportcan hang before reaching its process-exit timeout. Close stdin and boundwait_closed()withshutdown_timeout, allowing the existing terminate/kill fallback to run while preserving graceful flushing.Related issues
Applies the bounded stdin cleanup used by the Gemini example in #103 to the public transport helper.
Testing
make test: 362 passed, 1 skipped (optional Gemini CLI).make checkandmake docs-test: passed.Docs & screenshots
Clarified timeout behavior in the function docstring. No UI or schema changes.
Checklist
feat:,fix:).make gen-all) are called out if applicable.The author set the contribution scope and validation requirements; Codex assisted with implementation and automated testing.