Skip to content

add BoringSSL support - #7

Merged
Techatrix merged 1 commit into
allyourcodebase:masterfrom
LukasKastern:boringssl
Aug 13, 2026
Merged

add BoringSSL support#7
Techatrix merged 1 commit into
allyourcodebase:masterfrom
LukasKastern:boringssl

Conversation

@LukasKastern

@LukasKastern LukasKastern commented May 10, 2026

Copy link
Copy Markdown
Contributor

This PR integrates boringssl.
I've been using a variation of these changes for a while now.
I would like to upstream these changes to avoid relying on my fork in other projects.

Compile as

zig build -Dtarget=x86_64-windows -Doptimize=ReleaseFast -Dlibpsl=false -Dlibssh2=false -Dlibidn2=false -Dnghttp2=false -Ddisable-ldap -Duse-boringssl=true

And run

./zig-out/bin/curl https://httpbin.org/uuid

Output

{
  "uuid": "1e7c8860-cdab-4e05-881a-763665242b79"
}

Ideally we wait until the following PRs are merged to avoid relying on my forks in the boringssl repository.

@Techatrix Techatrix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged a PR that updated googletest to Zig 0.16.0 so this should be unblocked.

I'd prefer to keep the dependencies within the allyourcodebase organization if possible. Which would allow me and other members to more easily contribute if needed. Would you be open to join allyourcodebase and then contribute your boringssl port to it? More information on how to join can be found here:

https://github.com/allyourcodebase#im-a-zig-user-and-i-want-to-contribute-a-repository-how-can-i-do-it

Comment thread build.zig Outdated
@LukasKastern

Copy link
Copy Markdown
Contributor Author

I just merged a PR that updated googletest to Zig 0.16.0 so this should be unblocked.

I'd prefer to keep the dependencies within the allyourcodebase organization if possible. Which would allow me and other members to more easily contribute if needed. Would you be open to join allyourcodebase and then contribute your boringssl port to it? More information on how to join can be found here:

https://github.com/allyourcodebase#im-a-zig-user-and-i-want-to-contribute-a-repository-how-can-i-do-it

That makes sense! I'll update boringssl to use the merged googletest and ping kristoff about joining the org and moving the project over.

@LukasKastern
LukasKastern marked this pull request as ready for review July 12, 2026 15:41
@LukasKastern

Copy link
Copy Markdown
Contributor Author

I moved boringssl to the allyourcodebase org.
Let me know if you'd like me to revert the ca_bundle change or do any other changes!

@Techatrix

Copy link
Copy Markdown
Member

I pushed 78d0fc1 to match upstream with how it represents the use_boringssl build system flag. use_boringssl should imply use_openssl because it's a fork. Let me know if this regressed anything.

The usage of akunaakwei/zig-patch is problematic because it uses a custom build step. This will be removed in Zig 0.17.0 in favor of defining a std.Build.Step.Run step. It also appears to fail to properly cache its output.

This PR also needs a rebase. I'd recommend squashing the commits before doing so.

@LukasKastern

Copy link
Copy Markdown
Contributor Author

The usage of akunaakwei/zig-patch is problematic because it uses a custom build step. This will be removed in Zig 0.17.0 in favor of defining a std.Build.Step.Run step. It also appears to fail to properly cache its output.

I see. I've setup a PR to address your concern regarding defining custom steps.

This change also fixes the caching behaviour.

I'll rebase + update + check functionality again once we have that change.

@LukasKastern
LukasKastern force-pushed the boringssl branch 5 times, most recently from 157a531 to 7f94239 Compare August 13, 2026 18:14
@LukasKastern

Copy link
Copy Markdown
Contributor Author

Boringssl now uses the latest version of zig-patch which implements a run artifact based patching mechanism.

I've squashed the commits here and rebased to master.

I also tested that the changes still work with olksdr/sentry-native#2.

Let me know if there is something else remaining you'd like me to take a look at.

@Techatrix Techatrix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience to get through this long review process. Let's merge this!

@Techatrix
Techatrix merged commit c59c65c into allyourcodebase:master Aug 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants