Skip to content

GH-50631: [C++] Scope macOS SDK 11.3 simdjson workaround to bundled simdjson#50633

Open
Reranko05 wants to merge 1 commit into
apache:mainfrom
Reranko05:gh-50631-macos
Open

GH-50631: [C++] Scope macOS SDK 11.3 simdjson workaround to bundled simdjson#50633
Reranko05 wants to merge 1 commit into
apache:mainfrom
Reranko05:gh-50631-macos

Conversation

@Reranko05

@Reranko05 Reranko05 commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

The workaround introduced for the macOS 11.3 SDK currently uses a global add_compile_definitions(SIMDJSON_CONCEPT_DISABLED=1).

Since this workaround is only needed when building the bundled simdjson dependency, scope it to the simdjson target inside build_simdjson() instead of applying it globally.

What changes are included in this PR?

  • Move the macOS SDK 11.3 workaround into build_simdjson().
  • Replace the global add_compile_definitions() with target_compile_definitions(simdjson PRIVATE SIMDJSON_CONCEPT_DISABLED=1).

Copilot AI review requested due to automatic review settings July 25, 2026 01:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #50631 has been automatically assigned in GitHub to PR creator.

@Reranko05

Copy link
Copy Markdown
Contributor Author

@kou As suggested, I opened an upstream issue for this: simdjson/simdjson#2787

@kou

kou commented Jul 25, 2026

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g r

@kou kou added the CI: Extra Run extra CI label Jul 25, 2026
@github-actions

Copy link
Copy Markdown

Revision: fa60e5d

Submitted crossbow builds: ursacomputing/crossbow @ actions-343cdd513e

Task Status
r-binary-packages GitHub Actions
r-recheck-most GitHub Actions
test-r-alpine-linux-cran GitHub Actions
test-r-arrow-backwards-compatibility GitHub Actions
test-r-depsource-system GitHub Actions
test-r-dev-duckdb GitHub Actions
test-r-devdocs GitHub Actions
test-r-extra-packages GitHub Actions
test-r-fedora-clang GitHub Actions
test-r-gcc-11 GitHub Actions
test-r-gcc-12 GitHub Actions
test-r-install-local GitHub Actions
test-r-install-local-minsizerel GitHub Actions
test-r-linux-as-cran GitHub Actions
test-r-linux-rchk GitHub Actions
test-r-linux-sanitizers GitHub Actions
test-r-linux-valgrind GitHub Actions
test-r-m1-san GitHub Actions
test-r-macos-as-cran GitHub Actions
test-r-offline-maximal GitHub Actions
test-r-ubuntu-22.04 GitHub Actions
test-r-versions GitHub Actions
test-r-wasm GitHub Actions

Comment thread cpp/cmake_modules/ThirdpartyToolchain.cmake Outdated
@github-actions github-actions Bot added awaiting committer review Awaiting committer review awaiting changes Awaiting changes and removed awaiting review Awaiting review awaiting committer review Awaiting committer review labels Jul 25, 2026
Copilot AI review requested due to automatic review settings July 25, 2026 09:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting change review Awaiting change review CI: Extra Run extra CI Component: C++

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants