GH-50631: [C++] Scope macOS SDK 11.3 simdjson workaround to bundled simdjson#50633
Open
Reranko05 wants to merge 1 commit into
Open
GH-50631: [C++] Scope macOS SDK 11.3 simdjson workaround to bundled simdjson#50633Reranko05 wants to merge 1 commit into
Reranko05 wants to merge 1 commit into
Conversation
|
|
Contributor
Author
|
@kou As suggested, I opened an upstream issue for this: simdjson/simdjson#2787 |
Member
|
@github-actions crossbow submit -g r |
|
Revision: fa60e5d Submitted crossbow builds: ursacomputing/crossbow @ actions-343cdd513e |
Reranko05
commented
Jul 25, 2026
Reranko05
force-pushed
the
gh-50631-macos
branch
from
July 25, 2026 09:14
fa60e5d to
4c4d64c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The workaround introduced for the macOS 11.3 SDK currently uses a global
add_compile_definitions(SIMDJSON_CONCEPT_DISABLED=1).Since this workaround is only needed when building the bundled simdjson dependency, scope it to the
simdjsontarget insidebuild_simdjson()instead of applying it globally.What changes are included in this PR?
build_simdjson().add_compile_definitions()withtarget_compile_definitions(simdjson PRIVATE SIMDJSON_CONCEPT_DISABLED=1).