Add more tests for HuffmanDecoder and performance benchmark tests - #795
Merged
Merged
Conversation
garydgregory
requested changes
Aug 8, 2026
garydgregory
left a comment
Member
There was a problem hiding this comment.
Hello @fkjellberg
Thank you for the PR. Please see my comments.
fkjellberg
force-pushed
the
add-huffmandecoder-tests
branch
from
August 8, 2026 21:35
d1cce2e to
ad0400e
Compare
Contributor
Author
|
@garydgregory I updated the PR to use |
Member
|
Thank you @fkjellberg , merged 🚀 |
garydgregory
added a commit
that referenced
this pull request
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.I'm investigating if we can replace
BinaryTreeused byLhStaticHuffmanCompressorInputStreamwith the new genericHuffmanDecoder.ExplodingInputStreamis also using a similarBinaryTreeimplementation and could possibly useHuffmanDecoderas well but I will investigate that later on.There are some minor differences between the generic
HuffmanDecoderand how huffman trees are stored for LHA and I will create another PR to fix this once this PR has been merged.This PR just adds more unit tests for the
HuffmanDecoderand performance benchmark tests.